linux-kernel - Re: [PATCH v2] pmic: add mt6366 regulator document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 11 Aug 2022 11:58:10 +0300
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     "zhiyong.tao" <zhiyong.tao@...iatek.com>, lee.jones@...aro.org,
        robh+dt@...nel.org, matthias.bgg@...il.com, lgirdwood@...il.com,
        broonie@...nel.org, eddie.huang@...iatek.com, a.zummo@...ertech.it,
        alexandre.belloni@...tlin.com, fshao@...omium.org
Cc:     sen.chu@...iatek.com, hui.liu@...iatek.com,
        allen-kh.cheng@...iatek.com, hsin-hsiung.wang@...iatek.com,
        sean.wang@...iatek.com, macpaul.lin@...iatek.com,
        wen.su@...iatek.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org,
        Project_Global_Chrome_Upstream_Group@...iatek.com,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        zhiyong tao <zhiyong.tao@...iatk.com>
Subject: Re: [PATCH v2] pmic: add mt6366 regulator document

On 11/08/2022 11:42, zhiyong.tao wrote:
>>
>>>
>>> Signed-off-by: zhiyong tao <zhiyong.tao@...iatk.com>
>>> ---
>>>  .../regulator/mediatek,mt6366-regulator.yaml  | 375
>>> ++++++++++++++++++
>>>  1 file changed, 375 insertions(+)
>>
>> Subject does not match subsystem.
> 
> Hi Krzysztof,
> 
> Do you mean that we should change the title like this:
> regulator: dt-bindings: mediatek: add mt6366 regulator document
> is it right?

Yes. And remove redundant pieces so for example:

regulator: dt-bindings: mediatek: add mt6366
or:
regulator: dt-bindings: add mediatek,mt6366


(...)

>>> +    patternProperties:
>>> +      "^buck-
>>> v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$":
>>> +        type: object
>>> +        $ref: "regulator.yaml#"
>>
>> No need for quotes.
> ==>
> We will remove the line "$ref: "regulator.yaml#"" in next verison, is
> it right?

No, it is not. Why do you want to remove it?


Best regards,
Krzysztof