linux-kernel - Re: [PATCH] thermal: qcom: tsens-v0_1: Fix MSM8939 fourth sensor hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03ba7601-12dd-befc-eab1-14c3e9931519@linaro.org>
Date:   Thu, 11 Aug 2022 11:55:21 +0100
From:   Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To:     Vincent Knecht <vincent.knecht@...loo.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Amit Kucheria <amitk@...nel.org>,
        Thara Gopinath <thara.gopinath@...il.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Shawn Guo <shawn.guo@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        mchen@...areup.com
Subject: Re: [PATCH] thermal: qcom: tsens-v0_1: Fix MSM8939 fourth sensor
 hw_id

On 11/08/2022 11:50, Vincent Knecht wrote:
> Reading temperature from this sensor fails with 'Invalid argument'.
> 
> Looking at old vendor dts [1], its hw_id should be 3 instead of 4.
> Change this hw_id accordingly.
> 
> [1] https://github.com/msm8916-mainline/android_kernel_qcom_msm8916/blob/master/arch/arm/boot/dts/qcom/msm8939-common.dtsi#L511
> 
> Fixes: 332bc8ebab2c ("thermal: qcom: tsens-v0_1: Add support for MSM8939")
> Signed-off-by: Vincent Knecht <vincent.knecht@...loo.org>
> ---
> Fixes reading GPU temperature on msm8939 idol3 with current WIP dtsi
> ---
>   drivers/thermal/qcom/tsens-v0_1.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/qcom/tsens-v0_1.c b/drivers/thermal/qcom/tsens-v0_1.c
> index f136cb350238..327f37202c69 100644
> --- a/drivers/thermal/qcom/tsens-v0_1.c
> +++ b/drivers/thermal/qcom/tsens-v0_1.c
> @@ -604,7 +604,7 @@ static const struct tsens_ops ops_8939 = {
>   struct tsens_plat_data data_8939 = {
>   	.num_sensors	= 10,
>   	.ops		= &ops_8939,
> -	.hw_ids		= (unsigned int []){ 0, 1, 2, 4, 5, 6, 7, 8, 9, 10 },
> +	.hw_ids		= (unsigned int []){ 0, 1, 2, 3, 5, 6, 7, 8, 9, 10 },
>   
>   	.feat		= &tsens_v0_1_feat,
>   	.fields	= tsens_v0_1_regfields,

ACK we have this change in our shipping 4.19 kernel

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>