linux-kernel - Re: [PATCH v7 1/4] vdpa: Add suspend operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220811072125-mutt-send-email-mst@kernel.org>
Date:   Thu, 11 Aug 2022 07:23:44 -0400
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Eugenio Pérez <eperezma@...hat.com>,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jason Wang <jasowang@...hat.com>,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        dinang@...inx.com, martinpo@...inx.com,
        Wu Zongyong <wuzongyong@...ux.alibaba.com>,
        Piotr.Uminski@...el.com, gautam.dawar@....com,
        ecree.xilinx@...il.com, martinh@...inx.com,
        Stefano Garzarella <sgarzare@...hat.com>, pabloc@...inx.com,
        habetsm.xilinx@...il.com, lvivier@...hat.com,
        Zhu Lingshan <lingshan.zhu@...el.com>, tanuj.kamde@....com,
        Longpeng <longpeng2@...wei.com>, lulu@...hat.com,
        hanand@...inx.com, Parav Pandit <parav@...dia.com>,
        Si-Wei Liu <si-wei.liu@...cle.com>,
        Eli Cohen <elic@...dia.com>,
        Xie Yongji <xieyongji@...edance.com>,
        Zhang Min <zhang.min9@....com.cn>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH v7 1/4] vdpa: Add suspend operation

On Thu, Aug 11, 2022 at 01:15:08PM +0300, Dan Carpenter wrote:
> On Thu, Aug 11, 2022 at 04:27:32AM -0400, Michael S. Tsirkin wrote:
> > On Wed, Aug 10, 2022 at 07:15:09PM +0200, Eugenio Pérez wrote:
> > > This operation is optional: It it's not implemented, backend feature bit
> > > will not be exposed.
> > > 
> > > Signed-off-by: Eugenio Pérez <eperezma@...hat.com>
> > > Message-Id: <20220623160738.632852-2-eperezma@...hat.com>
> > > Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> > 
> > What is this message id doing here?
> > 
> 
> I like the Message-Id tag.  It means you can `b4 mbox <mesg-id>` and get
> the thread.

Yes it makes sense in git. But I don't see what it does in this patch
posted to the list. It seems to refer to the previous version of the
patch here. Which is ok I guess but better called out e.g.

Previous-version: <20220623160738.632852-2-eperezma@...hat.com>


> Linus has complained (rough remembering) that everyone is using the
> Link: tag for links to the patch itself.  It's supposed to be for Links
> to bugzilla or to the spec or whatever.  Extra information, too much to
> put in the commit message.  Now the Link tag is useless because it either
> points to the patch or to a bugzilla.  Depend on what you want it to do,
> it *always* points to the opposite thing.
> 
> But I can't remember what people settled on as the alternative to use
> to link to lore...
> 
> In theory, we should be able to figure out the link to lore automatically
> and there have been a couple projects which tried to do this but they
> can't make it work 100%.  Maintainers massage and reformat the patches
> too much before applying them.
> 
> regards,
> dan carpenter