linux-kernel - Re: [PATCH] mm/shmem: shmem_replace_page() remember NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YvTrQ1NRfnOEHGWD@casper.infradead.org>
Date:   Thu, 11 Aug 2022 12:42:59 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Hugh Dickins <hughd@...gle.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] mm/shmem: shmem_replace_page() remember NR_SHMEM

On Wed, Aug 10, 2022 at 10:06:33PM -0700, Hugh Dickins wrote:
> Elsewhere, NR_SHMEM is updated at the same time as shmem NR_FILE_PAGES;
> but shmem_replace_page() was forgetting to do that - so NR_SHMEM stats
> could grow too big or too small, in those unusual cases when it's used.
> 
> Signed-off-by: Hugh Dickins <hughd@...gle.com>

Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>

> ---
> This is not terribly important, and will clash with one of Matthew's
> 59 for 5.21; I don't mind if this gets delayed, and we just do it again
> on top of his series later, or he fold the equivalent into his series;
> but thought I'd better send it in as another fix to shmem_replace_page()
> while that function is on our minds.

Let's get this into 6.0 since it's a bugfix, and I'll rebase my patches
for 6.1 on top of it.