lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 11 Aug 2022 12:38:51 +0000 From: <Conor.Dooley@...rochip.com> To: <wsa@...nel.org>, <Daire.McNamara@...rochip.com>, <linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <andreas.buerkler@...lustra.com>, <Lewis.Hanly@...rochip.com> Subject: Re: [PATCH] i2c: microchip-core: fix erroneous late ack send On 11/08/2022 13:28, Wolfram Sang wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > On Fri, Aug 05, 2022 at 08:43:46AM +0100, Conor Dooley wrote: >> A late ack is currently being sent at the end of a transfer due to >> incorrect logic in mchp_corei2c_empty_rx(). Currently the Assert Ack >> bit is being written to the controller's control reg after the last >> byte has been received, causing it to sent another byte with the ack. >> Instead, the AA flag should be written to to the contol register when >> the penultimate byte is read so it is sent out for the last byte. >> >> Reported-by: Andreas Buerkler <andreas.buerkler@...lustra.com> >> Fixes: 64a6f1c4987e ("i2c: add support for microchip fpga i2c controllers") >> Tested-by: Lewis Hanly <lewis.hanly@...rochip.com> >> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com> > > Fixed these checkpatch warnings: > > WARNING: 'contol' may be misspelled - perhaps 'control'? > WARNING: Possible repeated word: 'to' Heh, that's what I get for editing the commit in send-email.. > > and applied to for-current, thanks! Thanks :) > >
Powered by blists - more mailing lists