linux-kernel - Re: [PATCH] cifs: Remove {cifs,nfs}_fscache_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2r5mubvk83SkDmiw0YUW2W6g0o7-Q3hr1KKtOC1DRRP6yOcQ@mail.gmail.com>
Date:   Wed, 10 Aug 2022 21:27:00 -0500
From:   Steve French <smfrench@...il.com>
To:     Jeff Layton <jlayton@...nel.org>
Cc:     David Howells <dhowells@...hat.com>,
        Matthew Wilcox <willy@...radead.org>,
        CIFS <linux-cifs@...r.kernel.org>,
        samba-technical <samba-technical@...ts.samba.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cifs: Remove {cifs,nfs}_fscache_release_page()

merged into cifs-2.6.git for-next

On Mon, Aug 8, 2022 at 9:51 AM Jeff Layton <jlayton@...nel.org> wrote:
>
> On Mon, 2022-08-08 at 15:33 +0100, David Howells wrote:
> > Remove {cifs,nfs}_fscache_release_page() from fs/cifs/fscache.h.  This
> > functionality got built directly into cifs_release_folio() and will
> > hopefully be replaced with netfs_release_folio() at some point.
> >
> > The "nfs_" version is a copy and paste error and should've been altered to
> > read "cifs_".  That can also be removed.
> >
> > Reported-by: Matthew Wilcox <willy@...radead.org>
> > Signed-off-by: David Howells <dhowells@...hat.com>
> > cc: Jeff Layton <jlayton@...hat.com>
> > cc: Steve French <smfrench@...il.com>
> > cc: linux-cifs@...r.kernel.org
> > cc: samba-technical@...ts.samba.org
> > cc: linux-fsdevel@...r.kernel.org
> > ---
> >
> >  fs/cifs/fscache.h |   16 ----------------
> >  1 file changed, 16 deletions(-)
> >
> > diff --git a/fs/cifs/fscache.h b/fs/cifs/fscache.h
> > index aa3b941a5555..67b601041f0a 100644
> > --- a/fs/cifs/fscache.h
> > +++ b/fs/cifs/fscache.h
> > @@ -108,17 +108,6 @@ static inline void cifs_readpage_to_fscache(struct inode *inode,
> >               __cifs_readpage_to_fscache(inode, page);
> >  }
> >
> > -static inline int cifs_fscache_release_page(struct page *page, gfp_t gfp)
> > -{
> > -     if (PageFsCache(page)) {
> > -             if (current_is_kswapd() || !(gfp & __GFP_FS))
> > -                     return false;
> > -             wait_on_page_fscache(page);
> > -             fscache_note_page_release(cifs_inode_cookie(page->mapping->host));
> > -     }
> > -     return true;
> > -}
> > -
> >  #else /* CONFIG_CIFS_FSCACHE */
> >  static inline
> >  void cifs_fscache_fill_coherency(struct inode *inode,
> > @@ -154,11 +143,6 @@ cifs_readpage_from_fscache(struct inode *inode, struct page *page)
> >  static inline
> >  void cifs_readpage_to_fscache(struct inode *inode, struct page *page) {}
> >
> > -static inline int nfs_fscache_release_page(struct page *page, gfp_t gfp)
> > -{
> > -     return true; /* May release page */
> > -}
> > -
> >  #endif /* CONFIG_CIFS_FSCACHE */
> >
> >  #endif /* _CIFS_FSCACHE_H */
> >
> >
>
> Reviewed-by: Jeff Layton <jlayton@...nel.org>



-- 
Thanks,

Steve