linux-kernel - Re: [PATCH net-next] net: skb: prevent the split of kfree_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=Eq1265hYhEVTGuh-_ZW+3HjWkwaktEfs7H7yPERfO0w@mail.gmail.com>
Date:   Thu, 11 Aug 2022 16:34:29 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     menglong8.dong@...il.com
Cc:     kuba@...nel.org, ojeda@...nel.org, ndesaulniers@...gle.com,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        asml.silence@...il.com, imagedong@...cent.com,
        luiz.von.dentz@...el.com, vasily.averin@...ux.dev,
        jk@...econstruct.com.au, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: skb: prevent the split of
 kfree_skb_reason() by gcc

On Thu, Aug 11, 2022 at 2:07 PM <menglong8.dong@...il.com> wrote:
>
> diff --git a/include/linux/compiler_attributes.h b/include/linux/compiler_attributes.h
> index 445e80517cab..51f7c13bca98 100644
> --- a/include/linux/compiler_attributes.h
> +++ b/include/linux/compiler_attributes.h
> @@ -371,4 +371,6 @@
>   */
>  #define __weak                          __attribute__((__weak__))
>
> +#define __nofnsplit                     __attribute__((optimize("O1")))
> +
>  #endif /* __LINUX_COMPILER_ATTRIBUTES_H */

Two notes on this: please use the double underscore form:
`__optimize__` and keep the file sorted (it should go after
`__overloadable__`, since we sort by the actual attribute name).

Thanks!

Cheers,
Miguel