linux-kernel - Re: [PATCH v3 4/6] asus-wmi: Document previously added attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0688d90-8b20-fc50-56ec-d50a5601f468@redhat.com>
Date:   Thu, 11 Aug 2022 17:08:06 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        "Luke D. Jones" <luke@...nes.dev>
Cc:     Barnabás Pőcze <pobrn@...tonmail.com>,
        Pavel Machek <pavel@....cz>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 4/6] asus-wmi: Document previously added attributes

Hi,

On 8/9/22 11:25, Andy Shevchenko wrote:
> On Tue, Aug 9, 2022 at 4:51 AM Luke D. Jones <luke@...nes.dev> wrote:
>>
>> Documents some previously added attributes:
>> - dgpu_disable
>> - egpu_enable
>> - panel_od
> 
> Try to find a commit that introduced thouse and add the respective Fixes tag.
> 
> ...
> 
>> -                       * keyboard - 0 or 1, unknown what effect this really has
>> \ No newline at end of file
>> +                       * keyboard - 0 or 1, unknown what effect this really has
> 
> Should be part of another patch.

Ack to both remarks.

Luke please make this patch one of the first patches in your next
version / patch-series and then add the doucmentation of the new
kbd RGB backlight attributes in the patches where you are also
adding those actual attributes.

Regards,

Hans