linux-kernel - Re: [PATCH] i915/gvt: Fix Comet Lake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 11 Aug 2022 10:29:44 +0800
From:   Zhenyu Wang <zhenyu.z.wang@...el.com>
To:     Alex Williamson <alex.williamson@...hat.com>
Cc:     zhi.a.wang@...el.com, intel-gvt-dev@...ts.freedesktop.org,
        intel-gfx@...ts.freedesktop.org, jani.nikula@...ux.intel.com,
        joonas.lahtinen@...ux.intel.com, rodrigo.vivi@...el.com,
        tvrtko.ursulin@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i915/gvt: Fix Comet Lake

On 2022.08.10 15:55:48 -0600, Alex Williamson wrote:
> Prior to the commit below the GAMT_CHKN_BIT_REG address was setup for
> devices matching (D_KBL | D_CFL), where intel_gvt_get_device_type()
> returns D_CFL for either Coffee Lake or Comet Lake.  Include the missed
> platform.`
> 
> Link: https://lore.kernel.org/all/20220808142711.02d16782.alex.williamson@redhat.com
> Fixes: e0f74ed4634d ("i915/gvt: Separate the MMIO tracking table from GVT-g")
> Signed-off-by: Alex Williamson <alex.williamson@...hat.com>
> ---
>  drivers/gpu/drm/i915/intel_gvt_mmio_table.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_gvt_mmio_table.c b/drivers/gpu/drm/i915/intel_gvt_mmio_table.c
> index 157e166672d7..5595639d0033 100644
> --- a/drivers/gpu/drm/i915/intel_gvt_mmio_table.c
> +++ b/drivers/gpu/drm/i915/intel_gvt_mmio_table.c
> @@ -1076,7 +1076,8 @@ static int iterate_skl_plus_mmio(struct intel_gvt_mmio_table_iter *iter)
>  	MMIO_D(GEN8_HDC_CHICKEN1);
>  	MMIO_D(GEN9_WM_CHICKEN3);
>  
> -	if (IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv))
> +	if (IS_KABYLAKE(dev_priv) ||
> +	    IS_COFFEELAKE(dev_priv) || IS_COMETLAKE(dev_priv))
>  		MMIO_D(GAMT_CHKN_BIT_REG);
>  	if (!IS_BROXTON(dev_priv))
>  		MMIO_D(GEN9_CTX_PREEMPT_REG);
> 

Thanks for catching this!

Reviewed-by: Zhenyu Wang <zhenyuw@...ux.intel.com>


Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)