linux-kernel - Re: [PATCH V6 0/6] RISC-V fixups to work with crash tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e070eac-edb7-ba89-f189-bed0fd0b1702@microchip.com>
Date:   Thu, 11 Aug 2022 15:45:16 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <xianting.tian@...ux.alibaba.com>, <paul.walmsley@...ive.com>,
        <palmer@...belt.com>, <aou@...s.berkeley.edu>,
        <anup@...infault.org>, <heiko@...ech.de>, <guoren@...nel.org>,
        <mick@....forth.gr>, <alexandre.ghiti@...onical.com>,
        <bhe@...hat.com>, <vgoyal@...hat.com>, <dyoung@...hat.com>,
        <corbet@....net>
CC:     <kexec@...ts.infradead.org>, <linux-doc@...r.kernel.org>,
        <linux-riscv@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <crash-utility@...hat.com>, <heinrich.schuchardt@...onical.com>,
        <k-hagio-ab@....com>, <hschauhan@...ltrace.org>,
        <yixun.lan@...il.com>
Subject: Re: [PATCH V6 0/6] RISC-V fixups to work with crash tool

Hey Xianting,
I still think the commit subjects could be more specific, but
not going to suggest wasting your time respinning for that.
Cosmetically:
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

@Palmer Would you consider at least patches 1-3 of the series
for 6.0?
Thanks,
Conor.

On 11/08/2022 08:41, Xianting Tian wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> I ever sent the patch 1 in the link:
> https://patchwork.kernel.org/project/linux-riscv/patch/20220708073150.352830-3-xianting.tian@linux.alibaba.com/
> And patch 2,3 in the link:
> https://patchwork.kernel.org/project/linux-riscv/patch/20220714113300.367854-2-xianting.tian@linux.alibaba.com/
> https://patchwork.kernel.org/project/linux-riscv/patch/20220714113300.367854-3-xianting.tian@linux.alibaba.com/
> 
> This patch set just put these patches together, and with three new patch 4, 5, 6.
> these six patches are the fixups for machine_kexec, kernel mode PC for vmcore
> and improvements for vmcoreinfo, memory layout dump and fixup schedule out issue
> in machine_crash_shutdown().
> 
> The main changes in the six patchs as below,
> Patch 1: Fixup use of smp_processor_id() in preemptible context, to cleanup
>          the console prints.
> Patch 2: Fixup to get correct kernel mode PC for kernel mode regs for vmcore.
> Patch 3: Fixup schedule out issue in machine_crash_shutdown()
> Patch 4: Add modules to virtual kernel memory layout dump.
> Patch 5: Add VM layout, va bits, ram base to vmcoreinfo, which can simplify
>          the development of crash tool as ARM64 already did
>          (arch/arm64/kernel/crash_core.c).
> Patch 6: Updates vmcoreinfo.rst for vmcoreinfo export for RISCV64.
> 
> With these six patches(patch 2 is must), crash tool can work well to analyze
> a vmcore. The patches for crash tool for RISCV64 is in the link:
> https://lore.kernel.org/linux-riscv/20220801043040.2003264-1-xianting.tian@linux.alibaba.com/
> 
> ------
> Changes v1 -> v2:
>   1, remove the patch "Add a fast call path of crash_kexec()" from this series
>      of patches, as it already applied to riscv git.
>      https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/commit/?h=for-next&id=3f1901110a89b0e2e13adb2ac8d1a7102879ea98
>   2, add 'Reviewed-by' based on the comments of v1.
> Changes v2 -> v3:
>   use "riscv" instead of "riscv64" in patch 5 subject line.
> Changes v3 -> v4:
>   use "riscv" instead of "riscv64" in the summary of patch 5 subject line.
> Changes v4 -> v5:
>   add a new patch "RISC-V: Fixup schedule out issue in machine_crash_shutdown()"
> Changes v5 -> v6:
>   1, move "fixup" patches to the start of the patch set.
>   2, change patch 1, 2, 6's subject to make it tell more what it's about.
>   3, add Fixes for patch 3.
>   4, adjuest the changes format for patch 6.
> 
> 
> Xianting Tian (6):
>   RISC-V: kexec: Fixup use of smp_processor_id() in preemptible context
>   RISC-V: Fixup get incorrect user mode PC for kernel mode regs
>   RISC-V: Fixup schedule out issue in machine_crash_shutdown()
>   RISC-V: Add modules to virtual kernel memory layout dump
>   RISC-V: Add arch_crash_save_vmcoreinfo support
>   Documentation: kdump: describe VMCOREINFO export for RISCV64
> 
>  .../admin-guide/kdump/vmcoreinfo.rst          | 31 +++++++++++++++++++
>  arch/riscv/kernel/Makefile                    |  1 +
>  arch/riscv/kernel/crash_core.c                | 29 +++++++++++++++++
>  arch/riscv/kernel/crash_save_regs.S           |  2 +-
>  arch/riscv/kernel/machine_kexec.c             | 28 ++++++++++++++---
>  arch/riscv/mm/init.c                          |  4 +++
>  6 files changed, 89 insertions(+), 6 deletions(-)
>  create mode 100644 arch/riscv/kernel/crash_core.c
> 
> --
> 2.17.1
>