linux-kernel - Re: [PATCH v2 2/2] USB: trancevibrator: simplify tv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YvXsPQjC83N9iNVI@kroah.com>
Date:   Fri, 12 Aug 2022 07:59:25 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Dongliang Mu <mudongliangabcd@...il.com>
Cc:     Dongliang Mu <dzm91@...t.edu.cn>, USB <linux-usb@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] USB: trancevibrator: simplify tv_probe

On Fri, Aug 12, 2022 at 08:21:00AM +0800, Dongliang Mu wrote:
> On Thu, Aug 11, 2022 at 5:06 PM Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >
> > On Thu, Aug 11, 2022 at 05:02:09PM +0800, Dongliang Mu wrote:
> > > From: Dongliang Mu <mudongliangabcd@...il.com>
> > >
> > > The function tv_probe does not need to invoke kfree when the
> > > allocation fails. So let's simplify the code of tv_probe.
> > >
> > > Signed-off-by: Dongliang Mu <mudongliangabcd@...il.com>
> > > ---
> > >  drivers/usb/misc/trancevibrator.c | 11 ++---------
> > >  1 file changed, 2 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/drivers/usb/misc/trancevibrator.c b/drivers/usb/misc/trancevibrator.c
> > > index 55cb63652eda..30d4d774d448 100644
> > > --- a/drivers/usb/misc/trancevibrator.c
> > > +++ b/drivers/usb/misc/trancevibrator.c
> > > @@ -84,22 +84,15 @@ static int tv_probe(struct usb_interface *interface,
> > >  {
> > >       struct usb_device *udev = interface_to_usbdev(interface);
> > >       struct trancevibrator *dev;
> > > -     int retval;
> > >
> > >       dev = kzalloc(sizeof(struct trancevibrator), GFP_KERNEL);
> > > -     if (!dev) {
> > > -             retval = -ENOMEM;
> > > -             goto error;
> > > -     }
> > > +     if (!dev)
> > > +             return -ENOMEM;
> > >
> > >       dev->udev = usb_get_dev(udev);
> > >       usb_set_intfdata(interface, dev);
> > >
> > >       return 0;
> > > -
> > > -error:
> > > -     kfree(dev);
> > > -     return retval;
> > >  }
> > >
> > >  static void tv_disconnect(struct usb_interface *interface)
> > > --
> > > 2.35.1
> > >
> >
> >
> > Hi,
> >
> > This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> > a patch that has triggered this response.  He used to manually respond
> > to these common problems, but in order to save his sanity (he kept
> > writing the same thing over and over, yet to different people), I was
> > created.  Hopefully you will not take offence and will fix the problem
> > in your patch and resubmit it so that it can be accepted into the Linux
> > kernel tree.
> >
> > You are receiving this message because of the following common error(s)
> > as indicated below:
> >
> > - This looks like a new version of a previously submitted patch, but you
> >   did not list below the --- line any changes from the previous version.
> >   Please read the section entitled "The canonical patch format" in the
> >   kernel file, Documentation/SubmittingPatches for what needs to be done
> >   here to properly describe this.
> 
> Sorry, Greg. I forget to add the changes:
> 
> v1->v2: fix the truncated subject of PATCH 2/2.
> 
> Shall I resend another v2 patch with change information or send a v3
> patch with this information?

v3 please.