linux-kernel - Re: [PATCH v10 13/13] dm: add power-of-2 target for zoned devices with non power-of-2 zone sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b250d97d-d0f2-0f89-dc02-a1bf54f8e43f@samsung.com>
Date:   Fri, 12 Aug 2022 09:25:18 +0200
From:   Pankaj Raghav <p.raghav@...sung.com>
To:     Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        <snitzer@...nel.org>, <axboe@...nel.dk>, <hch@....de>,
        <agk@...hat.com>
CC:     <linux-block@...r.kernel.org>, <Johannes.Thumshirn@....com>,
        <bvanassche@....org>, <matias.bjorling@....com>, <hare@...e.de>,
        <gost.dev@...sung.com>, <linux-nvme@...ts.infradead.org>,
        <jaegeuk@...nel.org>, <pankydev8@...il.com>,
        <linux-kernel@...r.kernel.org>, <dm-devel@...hat.com>,
        Damien Le Moal <damien.lemoal@....com>,
        Joel Granados <j.granados@...sung.com>
Subject: Re: [PATCH v10 13/13] dm: add power-of-2 target for zoned devices
 with non power-of-2 zone sizes

Hi Damien,

>> |--------------|---|--------------|---|
>> 0             3M  4M             7M  8M
>>
>> The area between target's zone capacity and zone size will be emulated
>> in the target.
>> The read IOs that fall in the emulated gap area will return 0 filled
>> bio and all the other IOs in that area will result in an error.
>> If a read IO span across the emulated area boundary, then the IOs are
>> split across them. All other IO operations that span across the emulated
>> area boundary will result in an error.
>>
>> The target can be easily created as follows:
>> dmsetup create <label> --table '0 <size_sects> po2zone /dev/nvme<id>'
>>
>> Note that the target does not support partial mapping of the underlying
>> device.
>>
>> Signed-off-by: Pankaj Raghav <p.raghav@...sung.com>
>> Suggested-by: Johannes Thumshirn <johannes.thumshirn@....com>
>> Suggested-by: Damien Le Moal <damien.lemoal@....com>
>> Suggested-by: Hannes Reinecke <hare@...e.de>
>> Reviewed-by: Joel Granados <j.granados@...sung.com>
> 
> You changed this patch. So it needs review again. Please do not carry previous
> review tags in that case.
> The changes were non-functional such as changing multiplication to
shifts and rephrasing error messages.

While I agree with your comment not to carry forward review tags if the
patch has changed, I thought it might be too much to ask a reviewer to
re-review for non-functional changes such as these. But I will request
Joel to do a quick re-review.

Thanks.