linux-kernel - [PATCH] io_uring: Optimizing return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 Aug 2022 10:00:00 +0800
From:   Zhang chunchao <chunchao@...china.com>
To:     axboe@...nel.dk, asml.silence@...il.com
Cc:     io-uring@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...china.com, Zhang chunchao <chunchao@...china.com>
Subject: [PATCH] io_uring: Optimizing return value

Delete return value ret Initialize assignment, change return value ret
to EOPNOTSUPP when IO_IS_URING_FOPS failed.

Signed-off-by: Zhang chunchao <chunchao@...china.com>
---
 io_uring/io_uring.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index b54218da075c..1b56f3d1a47b 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -3859,16 +3859,17 @@ SYSCALL_DEFINE4(io_uring_register, unsigned int, fd, unsigned int, opcode,
 		void __user *, arg, unsigned int, nr_args)
 {
 	struct io_ring_ctx *ctx;
-	long ret = -EBADF;
+	long ret;
 	struct fd f;
 
 	f = fdget(fd);
 	if (!f.file)
 		return -EBADF;
 
-	ret = -EOPNOTSUPP;
-	if (!io_is_uring_fops(f.file))
+	if (!io_is_uring_fops(f.file)) {
+		ret = -EOPNOTSUPP;
 		goto out_fput;
+	}
 
 	ctx = f.file->private_data;
 
-- 
2.18.2