linux-kernel - Re: [PATCH] net/sunrpc: fix potential memory leaks in rpc_sysfs_xprt_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166030021671.10916.13511850314728459485.git-patchwork-notify@kernel.org>
Date:   Fri, 12 Aug 2022 10:30:16 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Xin Xiong <xiongx18@...an.edu.cn>
Cc:     trond.myklebust@...merspace.com, anna@...nel.org,
        chuck.lever@...cle.com, jlayton@...nel.org, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        kolga@...app.com, linux-nfs@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        yuanxzhang@...an.edu.cn, tanxin.ctf@...il.com
Subject: Re: [PATCH] net/sunrpc: fix potential memory leaks in
 rpc_sysfs_xprt_state_change()

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@...emloft.net>:

On Wed, 10 Aug 2022 23:29:13 +0800 you wrote:
> The issue happens on some error handling paths. When the function
> fails to grab the object `xprt`, it simply returns 0, forgetting to
> decrease the reference count of another object `xps`, which is
> increased by rpc_sysfs_xprt_kobj_get_xprt_switch(), causing refcount
> leaks. Also, the function forgets to check whether `xps` is valid
> before using it, which may result in NULL-dereferencing issues.
> 
> [...]

Here is the summary with links:
  - net/sunrpc: fix potential memory leaks in rpc_sysfs_xprt_state_change()
    https://git.kernel.org/netdev/net/c/bfc48f1b0505

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html