linux-kernel - Re: [PATCH] block: Do not call blk_put_queue() if gendisk allocation fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166030813180.891934.12259200339444300073.b4-ty@kernel.dk>
Date:   Fri, 12 Aug 2022 06:42:11 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     rafaelmendsr@...il.com, hare@...e.de
Cc:     linux-block@...r.kernel.org, hdanton@...a.com,
        linux-kernel@...r.kernel.org,
        syzbot+31c9594f6e43b9289b25@...kaller.appspotmail.com
Subject: Re: [PATCH] block: Do not call blk_put_queue() if gendisk allocation fails

On Thu, 11 Aug 2022 20:23:37 -0300, Rafael Mendonca wrote:
> Commit 6f8191fdf41d ("block: simplify disk shutdown") removed the call
> to blk_get_queue() during gendisk allocation but missed to remove the
> corresponding cleanup code blk_put_queue() for it. Thus, if the gendisk
> allocation fails, the request_queue refcount gets decremented and
> reaches 0, causing blk_mq_release() to be called with a hctx still
> alive. That triggers a WARNING report, as found by syzkaller:
> 
> [...]

Applied, thanks!

[1/1] block: Do not call blk_put_queue() if gendisk allocation fails
      commit: aa0c680c3aa96a5f9f160d90dd95402ad578e2b0

Best regards,
-- 
Jens Axboe