linux-kernel - Re: [PATCH] perf: fix coding style in build-id.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YvZUTbEjvSLbUJQQ@kernel.org>
Date:   Fri, 12 Aug 2022 10:23:25 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Martin Liška <mliska@...e.cz>
Cc:     linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH] perf: fix coding style in build-id.c

Em Fri, Aug 12, 2022 at 01:42:56PM +0200, Martin Liška escreveu:
> Use tabs instead of 8 spaces for the indentation.

Thanks, applied.

- Arnaldo


> Signed-off-by: Martin Liska <mliska@...e.cz>
> ---
>  tools/perf/util/build-id.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c
> index 9e176146eb10..0cc68cdd84c8 100644
> --- a/tools/perf/util/build-id.c
> +++ b/tools/perf/util/build-id.c
> @@ -652,17 +652,17 @@ static char *build_id_cache__find_debug(const char *sbuild_id,
>  	nsinfo__mountns_exit(&nsc);
>  
>  #ifdef HAVE_DEBUGINFOD_SUPPORT
> -        if (realname == NULL) {
> -                debuginfod_client* c = debuginfod_begin();
> -                if (c != NULL) {
> -                        int fd = debuginfod_find_debuginfo(c,
> -                                                           (const unsigned char*)sbuild_id, 0,
> -                                                           &realname);
> -                        if (fd >= 0)
> -                                close(fd); /* retaining reference by realname */
> -                        debuginfod_end(c);
> -                }
> -        }
> +	if (realname == NULL) {
> +		debuginfod_client* c = debuginfod_begin();
> +		if (c != NULL) {
> +			int fd = debuginfod_find_debuginfo(c,
> +					(const unsigned char*)sbuild_id, 0,
> +					&realname);
> +			if (fd >= 0)
> +				close(fd); /* retaining reference by realname */
> +			debuginfod_end(c);
> +		}
> +	}
>  #endif
>  
>  out:
> -- 
> 2.37.1

-- 

- Arnaldo