lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 12 Aug 2022 15:46:20 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <robh+dt@...nel.org>, <mail@...chuod.ie>
CC:     <ulf.hansson@...aro.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <yamada.masahiro@...ionext.com>, <piotrs@...ence.com>,
        <linux-mmc@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH] dt-bindings: mmc: cdns: add card-detect-delay property

On 12/08/2022 16:33, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Thu, Aug 11, 2022 at 2:32 PM Conor Dooley <mail@...chuod.ie> wrote:
>>
>> From: Conor Dooley <conor.dooley@...rochip.com>
>>
>> Upgrading dt-schema to v2022.08 brings with it better handling of
>> unevaluatedProperties, exposing a previously undetected missing
>> property in the cadence sdhci dt-binding:
>> arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dtb: mmc@...08000: Unevaluated properties are not allowed ('card-detect-delay' was unexpected)
>>         From schema: Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
>>
>> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
>> ---
>> Should this have a fixes tag? If anything, it'd be
>> Fixes: 84723eec251d ("dt-bindings: mmc: cdns: document Microchip MPFS MMC/SDHCI controller")
>> but idk.
> 
> No, the common property 'cd-debounce-delay-ms' should be used instead.

So it's a case of "what's in the dts is wrong so it needs to change"?
For the future, where is the line drawn between "don't break the dts"
& "don't use bad properties"? Only if the property has consumers?
I don't mind, just want to get it right next time ;)

Thanks,
Conor.

Powered by blists - more mailing lists