linux-kernel - Re: [PATCH] dt-bindings: mmc: cdns: add card-detect-delay property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd3e5466-76e4-f678-5729-bfe9f2b0b811@microchip.com>
Date:   Fri, 12 Aug 2022 16:43:24 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <robh+dt@...nel.org>
CC:     <mail@...chuod.ie>, <ulf.hansson@...aro.org>,
        <krzysztof.kozlowski+dt@...aro.org>,
        <yamada.masahiro@...ionext.com>, <piotrs@...ence.com>,
        <linux-mmc@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH] dt-bindings: mmc: cdns: add card-detect-delay property

On 12/08/2022 17:38, Rob Herring wrote:
>>> No, the common property 'cd-debounce-delay-ms' should be used instead.
>>
>> So it's a case of "what's in the dts is wrong so it needs to change"?
> 
> Yes.
> 
>> For the future, where is the line drawn between "don't break the dts"
>> & "don't use bad properties"?
> 
> Depends...
> 
>> Only if the property has consumers?
>> I don't mind, just want to get it right next time ;)
> 
> In this case, there shouldn't be any compatibility issues because the
> mmc core has supported the common property longer than the dts
> existed. If that was not the case, then we'd probably be stuck with
> the property in the dts file. That still depends on usage in the
> kernel or elsewhere, in dts files, stability of the platform support,
> etc.

Cool, thanks Rob!