linux-kernel - Re: [PATCH] spi/panel: dt-bindings: drop 3-wire from common properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 Aug 2022 11:03:43 -0600
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     David Airlie <airlied@...ux.ie>, dri-devel@...ts.freedesktop.org,
        Christophe Branchereau <cbranchereau@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jonathan Bakker <xc-racer2@...e.ca>, linux-spi@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Mark Brown <broonie@...nel.org>,
        Paul Cercueil <paul@...pouillou.net>,
        Sam Ravnborg <sam@...nborg.org>, devicetree@...r.kernel.org,
        Daniel Vetter <daniel@...ll.ch>,
        Pratyush Yadav <p.yadav@...com>
Subject: Re: [PATCH] spi/panel: dt-bindings: drop 3-wire from common
 properties

On Wed, 10 Aug 2022 16:13:11 +0300, Krzysztof Kozlowski wrote:
> The spi-3wire property is device specific and should be accepted only if
> device really needs them.  Drop it from common spi-peripheral-props.yaml
> schema, mention in few panel drivers which use it and include instead in
> the SPI controller bindings.  The controller bindings will provide
> spi-3wire type validation and one place for description.  Each device
> schema must list the property if it is applicable.
> 
> The Samsung S6E63M0 panel uses also spi-cpha/cpol properties on at least
> one board (ste-ux500-samsung-janice/dts), so add also these to the
> panel's bindings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  .../bindings/display/panel/kingdisplay,kd035g6-54nt.yaml     | 2 ++
>  .../bindings/display/panel/leadtek,ltk035c5444t.yaml         | 2 ++
>  .../devicetree/bindings/display/panel/samsung,s6e63m0.yaml   | 4 ++++
>  Documentation/devicetree/bindings/spi/spi-controller.yaml    | 5 +++++
>  .../devicetree/bindings/spi/spi-peripheral-props.yaml        | 5 -----
>  5 files changed, 13 insertions(+), 5 deletions(-)
> 

Reviewed-by: Rob Herring <robh@...nel.org>