linux-kernel - Re: [PATCH] ASoC: Intel: sof_rt5682: Add support for jsl_rt5682

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 13 Aug 2022 03:09:40 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sean Hong <sean.hong@...nta.corp-partner.google.com>,
        perex@...ex.cz, tiwai@...e.com
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        cezary.rojewski@...el.com, pierre-louis.bossart@...ux.intel.com,
        liam.r.girdwood@...ux.intel.com, peter.ujfalusi@...ux.intel.com,
        yung-chuan.liao@...ux.intel.com, ranjani.sridharan@...ux.intel.com,
        kai.vehmanen@...ux.intel.com, broonie@...nel.org,
        brent.lu@...el.com, yong.zhi@...el.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        Sean Hong <sean.hong@...nta.corp-partner.google.com>
Subject: Re: [PATCH] ASoC: Intel: sof_rt5682: Add support for
 jsl_rt5682_rt1019

Hi Sean,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on broonie-sound/for-next]
[also build test ERROR on tiwai-sound/for-next linus/master next-20220812]
[cannot apply to v5.19]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sean-Hong/ASoC-Intel-sof_rt5682-Add-support-for-jsl_rt5682_rt1019/20220812-195139
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: i386-randconfig-a011 (https://download.01.org/0day-ci/archive/20220813/202208130220.892ZS1bh-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 5f1c7e2cc5a3c07cbc2412e851a7283c1841f520)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/5ab680d85b9dbcaa1929ab9beace3c9622e46d19
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Sean-Hong/ASoC-Intel-sof_rt5682-Add-support-for-jsl_rt5682_rt1019/20220812-195139
        git checkout 5ab680d85b9dbcaa1929ab9beace3c9622e46d19
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash sound/soc/intel/common/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> sound/soc/intel/common/soc-acpi-intel-jsl-match.c:35:2: error: expected ';' after top level declarator
   }
    ^
    ;
>> sound/soc/intel/common/soc-acpi-intel-jsl-match.c:89:4: error: field designator 'sof_fw_filename' does not refer to any field in type 'struct snd_soc_acpi_mach'
                   .sof_fw_filename = "sof-jsl.ri",
                    ^
   2 errors generated.


vim +35 sound/soc/intel/common/soc-acpi-intel-jsl-match.c

    31	
    32	static struct snd_soc_acpi_codecs rt1019p_spk = {
    33		.num_codecs = 1,
    34		.codecs = {"RTL1019"}
  > 35	}
    36	
    37	static const struct snd_soc_acpi_codecs mx98360a_spk = {
    38		.num_codecs = 1,
    39		.codecs = {"MX98360A"}
    40	};
    41	
    42	static const struct snd_soc_acpi_codecs rt5682_rt5682s_hp = {
    43		.num_codecs = 2,
    44		.codecs = {"10EC5682", "RTL5682"},
    45	};
    46	
    47	/*
    48	 * When adding new entry to the snd_soc_acpi_intel_jsl_machines array,
    49	 * use .quirk_data member to distinguish different machine driver,
    50	 * and keep ACPI .id field unchanged for the common codec.
    51	 */
    52	struct snd_soc_acpi_mach snd_soc_acpi_intel_jsl_machines[] = {
    53		{
    54			.id = "DLGS7219",
    55			.drv_name = "sof_da7219_mx98373",
    56			.sof_tplg_filename = "sof-jsl-da7219.tplg",
    57			.machine_quirk = snd_soc_acpi_codec_list,
    58			.quirk_data = &jsl_7219_98373_codecs,
    59		},
    60		{
    61			.id = "DLGS7219",
    62			.drv_name = "sof_da7219_mx98360a",
    63			.sof_tplg_filename = "sof-jsl-da7219-mx98360a.tplg",
    64		},
    65		{
    66			.comp_ids = &rt5682_rt5682s_hp,
    67			.drv_name = "jsl_rt5682_rt1015",
    68			.machine_quirk = snd_soc_acpi_codec_list,
    69			.quirk_data = &rt1015_spk,
    70			.sof_tplg_filename = "sof-jsl-rt5682-rt1015.tplg",
    71		},
    72		{
    73			.comp_ids = &rt5682_rt5682s_hp,
    74			.drv_name = "jsl_rt5682_rt1015p",
    75			.machine_quirk = snd_soc_acpi_codec_list,
    76			.quirk_data = &rt1015p_spk,
    77			.sof_tplg_filename = "sof-jsl-rt5682-rt1015.tplg",
    78		},
    79		{
    80			.comp_ids = &rt5682_rt5682s_hp,
    81			.drv_name = "jsl_rt5682_mx98360",
    82			.machine_quirk = snd_soc_acpi_codec_list,
    83			.quirk_data = &mx98360a_spk,
    84			.sof_tplg_filename = "sof-jsl-rt5682-mx98360a.tplg",
    85		},
    86		{
    87			.comp_ids = &rt5682_rt5682s_hp,
    88			.drv_name = "jsl_rt5682_rt1019",
  > 89			.sof_fw_filename = "sof-jsl.ri",

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp