linux-kernel - Re: [PATCH v3] PCI: endpoint: pci-epf-vntb: reduce several globals to statics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220812192124.GA1678588@bhelgaas>
Date:   Fri, 12 Aug 2022 14:21:24 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Jon Mason <jdmason@...zu.us>
Cc:     Tom Rix <trix@...hat.com>, kishon@...com, lpieralisi@...nel.org,
        kw@...ux.com, bhelgaas@...gle.com, Frank.Li@....com,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] PCI: endpoint: pci-epf-vntb: reduce several globals
 to statics

On Fri, Aug 12, 2022 at 10:13:59AM -0400, Jon Mason wrote:
> On Tue, Jul 12, 2022 at 03:05:27PM -0500, Bjorn Helgaas wrote:
> > Handled via Jon, I guess?
> > 
> > I'm unclear on the future direction of pci-epf-vntb.c.  Jon, are you
> > signing up to maintain this?  MAINTAINERS doesn't seem to reflect
> > that, even in next-20220712, so you're not being copied on everything.
> > 
> > If you are planning to merge and maintain this file, it would be
> > helpful to me if you acknowledge patches you merge so I know to ignore
> > them.
> 
> I massively dropped the ball on all the EPF stuff.  I appologize profusely.

No worries, sounds like you're getting everything sorted out :)

> I'm pulling it into my ntb tree bcause of the patch dependencies.  If
> you want me to own this stuff because it has ntb in it, then I can do
> a matainers entry to reflect it.  My assumption is that because it is
> under the drivers/pci umbrella it is yours (unless you want me to own
> it).  100% defer to your decision.

This patch dependency thing feels like a one-time or at least unusual
situation.  Unless it becomes a problem, I think it makes sense to
keep the drivers/pci umbrella instead of carving bits out of the
middle.

Even if I continue to merge everything under drivers/pci, maybe we
should consider an update like this just so you get cc'd on updates to
these files?

diff --git a/MAINTAINERS b/MAINTAINERS
index 08a5d70ceef9..5bafe7e8c2b2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14466,6 +14466,7 @@ W:	https://github.com/jonmason/ntb/wiki
 T:	git git://github.com/jonmason/ntb.git
 F:	drivers/net/ntb_netdev.c
 F:	drivers/ntb/
+F:	drivers/pci/endpoint/functions/pci-epf-*ntb.c
 F:	include/linux/ntb.h
 F:	include/linux/ntb_transport.h
 F:	tools/testing/selftests/ntb/