linux-kernel - Re: [PATCH] mm/damon/core: simplify the parameter passing for region split operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 13 Aug 2022 03:30:18 +0800
From:   kernel test robot <lkp@...el.com>
To:     xiakaixu1987@...il.com, sj@...nel.org, akpm@...ux-foundation.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        damon@...ts.linux.dev, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Kaixu Xia <kaixuxia@...cent.com>
Subject: Re: [PATCH] mm/damon/core: simplify the parameter passing for region
 split operation

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/xiakaixu1987-gmail-com/mm-damon-core-simplify-the-parameter-passing-for-region-split-operation/20220812-154316
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
config: hexagon-randconfig-r045-20220812 (https://download.01.org/0day-ci/archive/20220813/202208130308.8rYWTL9U-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 5f1c7e2cc5a3c07cbc2412e851a7283c1841f520)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/26b7d93b0f64c71d6d324a4a37d85641b55eaec2
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review xiakaixu1987-gmail-com/mm-damon-core-simplify-the-parameter-passing-for-region-split-operation/20220812-154316
        git checkout 26b7d93b0f64c71d6d324a4a37d85641b55eaec2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from mm/damon/core.c:1218:
>> mm/damon/core-test.h:129:33: error: too many arguments to function call, expected 3, have 4
           damon_split_region_at(c, t, r, 25);
           ~~~~~~~~~~~~~~~~~~~~~          ^~
   mm/damon/core.c:930:13: note: 'damon_split_region_at' declared here
   static void damon_split_region_at(struct damon_target *t,
               ^
   In file included from mm/damon/core.c:1218:
   mm/damon/core-test.h:222:31: error: too many arguments to function call, expected 2, have 3
           damon_split_regions_of(c, t, 2);
           ~~~~~~~~~~~~~~~~~~~~~~       ^
   mm/damon/core.c:948:13: note: 'damon_split_regions_of' declared here
   static void damon_split_regions_of(struct damon_target *t, int nr_subs)
               ^
   In file included from mm/damon/core.c:1218:
   mm/damon/core-test.h:229:31: error: too many arguments to function call, expected 2, have 3
           damon_split_regions_of(c, t, 4);
           ~~~~~~~~~~~~~~~~~~~~~~       ^
   mm/damon/core.c:948:13: note: 'damon_split_regions_of' declared here
   static void damon_split_regions_of(struct damon_target *t, int nr_subs)
               ^
   3 errors generated.


vim +129 mm/damon/core-test.h

17ccae8bb5c928 SeongJae Park 2021-09-07  119  
17ccae8bb5c928 SeongJae Park 2021-09-07  120  static void damon_test_split_at(struct kunit *test)
17ccae8bb5c928 SeongJae Park 2021-09-07  121  {
17ccae8bb5c928 SeongJae Park 2021-09-07  122  	struct damon_ctx *c = damon_new_ctx();
17ccae8bb5c928 SeongJae Park 2021-09-07  123  	struct damon_target *t;
17ccae8bb5c928 SeongJae Park 2021-09-07  124  	struct damon_region *r;
17ccae8bb5c928 SeongJae Park 2021-09-07  125  
1971bd630452e9 SeongJae Park 2022-03-22  126  	t = damon_new_target();
17ccae8bb5c928 SeongJae Park 2021-09-07  127  	r = damon_new_region(0, 100);
17ccae8bb5c928 SeongJae Park 2021-09-07  128  	damon_add_region(r, t);
17ccae8bb5c928 SeongJae Park 2021-09-07 @129  	damon_split_region_at(c, t, r, 25);
17ccae8bb5c928 SeongJae Park 2021-09-07  130  	KUNIT_EXPECT_EQ(test, r->ar.start, 0ul);
17ccae8bb5c928 SeongJae Park 2021-09-07  131  	KUNIT_EXPECT_EQ(test, r->ar.end, 25ul);
17ccae8bb5c928 SeongJae Park 2021-09-07  132  
17ccae8bb5c928 SeongJae Park 2021-09-07  133  	r = damon_next_region(r);
17ccae8bb5c928 SeongJae Park 2021-09-07  134  	KUNIT_EXPECT_EQ(test, r->ar.start, 25ul);
17ccae8bb5c928 SeongJae Park 2021-09-07  135  	KUNIT_EXPECT_EQ(test, r->ar.end, 100ul);
17ccae8bb5c928 SeongJae Park 2021-09-07  136  
17ccae8bb5c928 SeongJae Park 2021-09-07  137  	damon_free_target(t);
17ccae8bb5c928 SeongJae Park 2021-09-07  138  	damon_destroy_ctx(c);
17ccae8bb5c928 SeongJae Park 2021-09-07  139  }
17ccae8bb5c928 SeongJae Park 2021-09-07  140  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp