linux-kernel - Re: [PATCH] treewide: Unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <687da07e-ad0a-dd47-5f54-27f55e2d9b96@microchip.com>
Date:   Sat, 13 Aug 2022 16:13:59 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <tangmin@...rlc.com>, <anton@...era.com>
CC:     <linux-ntfs-dev@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] treewide: Unneeded semicolon

On 13/08/2022 17:07, min tang wrote:
> [PATCH] treewide: Unneeded semicolon

Hey, you might want to check whatever script you're using to
generate these commits. A single line change in a file isn't
exactly treewide...

> There is no semicolon after '}' in line 1615.

This doesn't really make much sense, maybe:
"Remove uneeded semicolon after..."
Thanks,
Conor.

> 
> Signed-off-by: min tang <tangmin@...rlc.com>
> ---
>  fs/ntfs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c
> index 5ae8de09b271..d663b49df84e 100644
> --- a/fs/ntfs/super.c
> +++ b/fs/ntfs/super.c
> @@ -1612,7 +1612,7 @@ static bool load_and_init_attrdef(ntfs_volume *vol)
>  		memcpy((u8*)vol->attrdef + (index++ << PAGE_SHIFT),
>  				page_address(page), size);
>  		ntfs_unmap_page(page);
> -	};
> +	}
>  	if (size == PAGE_SIZE) {
>  		size = i_size & ~PAGE_MASK;
>  		if (size)