linux-kernel - Re: [ata] 0568e61225: stress-ng.copy-file.ops_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b900d3b-9b52-5bc3-4ba8-24249f3c2e42@huawei.com>
Date:   Sat, 13 Aug 2022 08:23:36 +0100
From:   John Garry <john.garry@...wei.com>
To:     Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        Oliver Sang <oliver.sang@...el.com>
CC:     Christoph Hellwig <hch@....de>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "Linux Memory Management List" <linux-mm@...ck.org>,
        <linux-ide@...r.kernel.org>, <lkp@...ts.01.org>, <lkp@...el.com>,
        <ying.huang@...el.com>, <feng.tang@...el.com>,
        <zhengjun.xing@...ux.intel.com>, <fengwei.yin@...el.com>
Subject: Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0%
 regression

On 12/08/2022 19:27, Damien Le Moal wrote:
>> Interestingly ata dev max_sectors kb also gets capped from 32MB (LBA48)
>> -> 256KB due to swiotlb max mapping size. (It would be capped by shost
>> default max sectors 512KB without that swiotlb limit). I assume capping
>> due to swiotlb limit is not occuring on Oliver's machine.
> Yes, I was suspecting that we may be seeing a difference for anything that is
> not AHCI, e.g. with other drivers.
> 
> But that seems to be the correct thing to do, no ? 
Yes, this should be the correct thing to do.

 > How was this working before
 > without applying the swiotlb limit ?
 >
Not sure. I would need to check the libata code for how it handles DMA 
mapping errors, which I assume would occur for when we exceed the 
swiotlb limit.

Having said this, from limited testing, whenever I check megaraid sas or 
mpt3sas for performance, the length of request data never/rarely comes 
close to max sectors. That why I am surprised with the regression which 
Oliver reports.

Thanks,
John