linux-kernel - Re: [PATCH 2/2] virt: vmgenid: add support for generation counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202208141147.UE8mhW6c-lkp@intel.com>
Date:   Sun, 14 Aug 2022 11:26:26 +0800
From:   kernel test robot <lkp@...el.com>
To:     bchalios@...zon.es, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, bchalios@...zon.es, tytso@....edu,
        Jason@...c4.com, dwmw@...zon.co.uk, graf@...zon.de,
        xmarcalx@...zon.co.uk, gregkh@...uxfoundation.org
Subject: Re: [PATCH 2/2] virt: vmgenid: add support for generation counter

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on crng-random/master]
[also build test WARNING on linus/master v5.19 next-20220812]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/bchalios-amazon-es/virt-vmgenid-add-generation-counter/20220803-232559
base:   git://git.kernel.org/pub/scm/linux/kernel/git/crng/random.git master
reproduce: make htmldocs

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> Documentation/virt/vmgenid.rst:79: WARNING: Inline literal start-string without end-string.
>> Documentation/virt/vmgenid.rst:79: WARNING: Inline emphasis start-string without end-string.
>> Documentation/virt/vmgenid.rst:89: WARNING: Unexpected indentation.
>> Documentation/virt/vmgenid.rst:98: WARNING: Definition list ends without a blank line; unexpected unindent.
>> Documentation/virt/vmgenid.rst:102: WARNING: Inline interpreted text or phrase reference start-string without end-string.
>> Documentation/virt/vmgenid.rst: WARNING: document isn't included in any toctree

vim +79 Documentation/virt/vmgenid.rst

    78	
  > 79	```
    80	uint32_t *gen_cntr = mmaped_gen_counter();
    81	uint32_t cached_gen_cntr = *gen_cntr;
    82	char *secret;
    83	
    84	for(;;) {
    85	    secret = get_secret();
    86	
    87	    // All good, not restore has happened.
    88	    if (cached_gen_cntr == *gen_cntr)
  > 89	        break;
    90	
    91	    // Generation counter has changed. We need to recreate caches and try again
    92	
    93	    cached_gen_cntr = *gen_cntr;
    94	    barrier();
    95	
    96	    // recreate secrets' cache
    97	    rebuild_cache();
  > 98	}
    99	
   100	consume_secret(secret);
   101	
 > 102	```
   103	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp