linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: fix wrong continue condition in GC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65562b32-505f-796e-305a-d1b03baeb388@kernel.org>
Date:   Mon, 15 Aug 2022 11:52:28 +0800
From:   Chao Yu <chao@...nel.org>
To:     Jaegeuk Kim <jaegeuk@...nel.org>, linux-kernel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net
Cc:     stable@...nel.org
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix wrong continue condition in GC

On 2022/8/13 22:37, Jaegeuk Kim wrote:
> We should decrease the frozen counter.
> 
> Cc: stable@...nel.org
> Fixes: 325163e9892b ("f2fs: add gc_urgent_high_remaining sysfs node")
> Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>
> ---
>   fs/f2fs/gc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index 6da21d405ce1..7e4b41240d59 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -102,7 +102,7 @@ static int gc_thread_func(void *data)
>   					sbi->gc_urgent_high_limited = false;
>   					spin_unlock(&sbi->gc_urgent_high_lock);
>   					sbi->gc_mode = GC_NORMAL;
> -					continue;
> +					goto next;
>   				}
>   				sbi->gc_urgent_high_remaining--;
>   			}

Why not:

	if (!sbi->gc_urgent_high_remaining) {
		sbi->gc_urgent_high_limited = false;
		spin_unlock(&sbi->gc_urgent_high_lock);
		sbi->gc_mode = GC_NORMAL;
	} else {
		sbi->gc_urgent_high_remaining--;
	}

Thanks,