linux-kernel - Re: [syzbot] WARNING: suspicious RCU usage in bpf_sk_reuseport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220815113022.47f28352@kernel.org>
Date:   Mon, 15 Aug 2022 11:30:22 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     syzbot <syzbot+24bcff6e82ce253f23ec@...kaller.appspotmail.com>,
        bpf@...r.kernel.org, davem@...emloft.net, ecree.xilinx@...il.com,
        edumazet@...gle.com, habetsm.xilinx@...il.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        pabeni@...hat.com, syzkaller-bugs@...glegroups.com,
        Hawkins Jiawei <yin31149@...il.com>,
        Jakub Sitnicki <jakub@...udflare.com>
Subject: Re: [syzbot] WARNING: suspicious RCU usage in
 bpf_sk_reuseport_detach

On Mon, 15 Aug 2022 14:28:58 +0200 Daniel Borkmann wrote:
> [ +Hawkins ]
> 
> On 8/15/22 12:59 PM, syzbot wrote:
> > Hello,
> > 
> > syzbot found the following issue on:
> > 
> > HEAD commit:    94ce3b64c62d net/tls: Use RCU API to access tls_ctx->netdev
> > git tree:       net
> > console+strace: https://syzkaller.appspot.com/x/log.txt?x=14641e15080000
> > kernel config:  https://syzkaller.appspot.com/x/.config?x=53da55f2bdeb0d4c
> > dashboard link: https://syzkaller.appspot.com/bug?extid=24bcff6e82ce253f23ec
> > compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=106c89fd080000
> > C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=17ead885080000
> > 
> > The issue was bisected to:
> > 
> > commit f72c38fad234759fe943cb2e40bf3d0f7de1d4d9
> > Author: Edward Cree <ecree.xilinx@...il.com>
> > Date:   Wed Jul 20 18:33:48 2022 +0000
> > 
> >      sfc: hook up ef100 representor TX  
> 
> Looks rather related to:
> 
> commit 2a0133723f9ebeb751cfce19f74ec07e108bef1f
> Author: Hawkins Jiawei <yin31149@...il.com>
> Date:   Fri Aug 5 15:48:34 2022 +0800
> 
>      net: fix refcount bug in sk_psock_get (2)

Indeed, looks like the reuseport clearing needs to be some
approximation of rcu_dereference_protected().