linux-kernel - RE: [PATCH v2] AMD_SFH: Add a DMI quirk entry for Chromebooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MN0PR12MB6101E98363A22A66662B3D69E2689@MN0PR12MB6101.namprd12.prod.outlook.com>
Date:   Mon, 15 Aug 2022 18:36:39 +0000
From:   "Limonciello, Mario" <Mario.Limonciello@....com>
To:     Akihiko Odaki <akihiko.odaki@...il.com>,
        "Natikar, Basavaraj" <Basavaraj.Natikar@....com>
CC:     "Natikar, Basavaraj" <Basavaraj.Natikar@....com>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] AMD_SFH: Add a DMI quirk entry for Chromebooks

[Public]

> -----Original Message-----
> From: Akihiko Odaki <akihiko.odaki@...il.com>
> Sent: Thursday, July 14, 2022 23:46
> To: Natikar, Basavaraj <Basavaraj.Natikar@....com>
> Cc: Natikar, Basavaraj <Basavaraj.Natikar@....com>; Jiri Kosina
> <jikos@...nel.org>; Benjamin Tissoires <benjamin.tissoires@...hat.com>;
> linux-input@...r.kernel.org; linux-kernel@...r.kernel.org; Limonciello,
> Mario <Mario.Limonciello@....com>
> Subject: Re: [PATCH v2] AMD_SFH: Add a DMI quirk entry for Chromebooks
> 
> On 2022/07/15 13:41, Basavaraj Natikar wrote:
> >
> >
> > On 7/14/2022 11:07 AM, Akihiko Odaki wrote:
> >> Google Chromebooks use Chrome OS Embedded Controller Sensor Hub
> instead
> >> of Sensor Hub Fusion and leaves MP2 uninitialized, which disables all
> >> functionalities, even including the registers necessary for feature
> >> detections.
> >>
> >> The behavior was observed with Lenovo ThinkPad C13 Yoga.
> >>
> >>
> > This driver should not get loaded in chrome OS by default.
> > Could you please provide details of Chrome OS Version and Kernel version
> to confirm the behavior.
> >
> > Are you enabling manually CONFIG_AMD_SFH_HID config?
> >
> > Thanks,
> > Basavaraj
> >
> 
> I use Fedora 36, not Chrome OS. The config is enabled on Fedora's
> generic kernel. The kernel is built from commit
> 78ca55889a549a9a194c6ec666836329b774ab6d from the upstream.
> 
> Regards,
> Akihiko Odaki

Akihiko,

FWIW - I think your patch is the correct direction for your situation (trying to load
Fedora onto a system that previously shipped with ChromeOS).

I think you just need to check the question that I had about discovery registers and
if that probing is still a problem or not.

Thanks,