linux-kernel - Re: [PATCH 1/2] mmc: pxamci: Fix an error handling path in pxamci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFoZ-kzFPM88TCdgL7LLzB144oiEfCpofafLvTz51y3Hng@mail.gmail.com>
Date:   Mon, 15 Aug 2022 20:27:46 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Daniel Mack <daniel@...que.org>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-mmc@...r.kernel.org
Subject: Re: [PATCH 1/2] mmc: pxamci: Fix an error handling path in pxamci_probe()

On Tue, 26 Jul 2022 at 21:15, Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> The commit in Fixes: has moved some code around without updating gotos to
> the error handling path.
>
> Update it now and release some resources if pxamci_of_init() fails.
>
> Fixes: fa3a5115469c ("mmc: pxamci: call mmc_of_parse()")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Applied for fixes and by adding stable tag, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/pxamci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
> index 0db9490dc659..37bf362a0ed5 100644
> --- a/drivers/mmc/host/pxamci.c
> +++ b/drivers/mmc/host/pxamci.c
> @@ -648,7 +648,7 @@ static int pxamci_probe(struct platform_device *pdev)
>
>         ret = pxamci_of_init(pdev, mmc);
>         if (ret)
> -               return ret;
> +               goto out;
>
>         host = mmc_priv(mmc);
>         host->mmc = mmc;
> --
> 2.34.1
>