linux-kernel - Re: [PATCH] PCI: endpoint: fix Kconfig indent style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Aug 2022 13:41:42 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Shunsuke Mie <mie@...l.co.jp>
Cc:     Jon Mason <jdmason@...zu.us>,
        Kishon Vijay Abraham I <kishon@...com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Frank Li <Frank.Li@....com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Ren Zhijie <renzhijie2@...wei.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: endpoint: fix Kconfig indent style

On Mon, Aug 15, 2022 at 11:50:06AM +0900, Shunsuke Mie wrote:
> Change to follow the Kconfig style guide. This patch fixes to use tab
> rather than space to indent, while help text is indented an additional
> two spaces.
> 
> Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP")
> Signed-off-by: Shunsuke Mie <mie@...l.co.jp>

Thanks for doing this.  In the future make the subject line match the
history, e.g.,

  $ git log --oneline drivers/pci/endpoint/functions/Kconfig
  556a2c7dca33 ("PCI: endpoint: Fix Kconfig dependency")
  e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP")
  8b821cf76150 ("PCI: endpoint: Add EP function driver to provide NTB functionality")
  98dbf5af4fdd ("PCI: endpoint: Select CRC32 to fix test build error")
  349e7a85b25f ("PCI: endpoint: functions: Add an EP function to test PCI")

Note that these are all capitalized ("Fix Kconfig indent style").

Lorenzo will likely fix this up when applying, so no need to repost
for this.

> ---
>  drivers/pci/endpoint/functions/Kconfig | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/pci/endpoint/functions/Kconfig b/drivers/pci/endpoint/functions/Kconfig
> index 295a033ee9a2..9fd560886871 100644
> --- a/drivers/pci/endpoint/functions/Kconfig
> +++ b/drivers/pci/endpoint/functions/Kconfig
> @@ -27,13 +27,13 @@ config PCI_EPF_NTB
>  	  If in doubt, say "N" to disable Endpoint NTB driver.
>  
>  config PCI_EPF_VNTB
> -        tristate "PCI Endpoint NTB driver"
> -        depends on PCI_ENDPOINT
> -        depends on NTB
> -        select CONFIGFS_FS
> -        help
> -          Select this configuration option to enable the Non-Transparent
> -          Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB
> -          between PCI Root Port and PCIe Endpoint.
> +	tristate "PCI Endpoint NTB driver"
> +	depends on PCI_ENDPOINT
> +	depends on NTB
> +	select CONFIGFS_FS
> +	help
> +	  Select this configuration option to enable the Non-Transparent
> +	  Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB
> +	  between PCI Root Port and PCIe Endpoint.
>  
> -          If in doubt, say "N" to disable Endpoint NTB driver.
> +	  If in doubt, say "N" to disable Endpoint NTB driver.
> -- 
> 2.17.1
>