linux-kernel - Re: [PATCH] kunit: fix Kconfig for build-in tests USB4 and Nitro Enclaves

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05dbdf57-e990-465d-e4cc-e83e7f2b697a@amazon.com>
Date:   Mon, 15 Aug 2022 08:44:42 +0300
From:   "Paraschiv, Andra-Irina" <andraprs@...zon.com>
To:     Nico Pache <npache@...hat.com>, <kunit-dev@...glegroups.com>,
        <linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <davidgow@...gle.com>
CC:     <skhan@...uxfoundation.org>, <dlatypov@...gle.com>,
        <brendan.higgins@...ux.dev>, <alcioa@...zon.com>,
        <lexnv@...zon.com>, <YehezkelShB@...il.com>,
        <mika.westerberg@...ux.intel.com>, <michael.jamet@...el.com>,
        <andreas.noever@...il.com>
Subject: Re: [PATCH] kunit: fix Kconfig for build-in tests USB4 and Nitro
 Enclaves



On 11.08.2022 02:40, Nico Pache wrote:
> 
> Both the USB4 and Nitro Enclaves KUNIT tests are now able to be compiled
> if KUNIT is compiled as a module. This leads to issues if KUNIT is being
> packaged separately from the core kernel and when KUNIT is run baremetal
> without the required driver compiled into the kernel.
> 
> Fixes: 635dcd16844b ("thunderbolt: test: Use kunit_test_suite() macro")
> Fixes: fe5be808fa6c ("nitro_enclaves: test: Use kunit_test_suite() macro")
> Signed-off-by: Nico Pache <npache@...hat.com>
> ---
>   drivers/thunderbolt/Kconfig         | 3 +--
>   drivers/virt/nitro_enclaves/Kconfig | 2 +-
>   2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/thunderbolt/Kconfig b/drivers/thunderbolt/Kconfig
> index e76a6c173637..f12d0a3ee3e2 100644
> --- a/drivers/thunderbolt/Kconfig
> +++ b/drivers/thunderbolt/Kconfig
> @@ -29,8 +29,7 @@ config USB4_DEBUGFS_WRITE
> 
>   config USB4_KUNIT_TEST
>          bool "KUnit tests" if !KUNIT_ALL_TESTS
> -       depends on (USB4=m || KUNIT=y)
> -       depends on KUNIT
> +       depends on USB4 && KUNIT=y
>          default KUNIT_ALL_TESTS
> 
>   config USB4_DMA_TEST
> diff --git a/drivers/virt/nitro_enclaves/Kconfig b/drivers/virt/nitro_enclaves/Kconfig
> index ce91add81401..dc4d25c26256 100644
> --- a/drivers/virt/nitro_enclaves/Kconfig
> +++ b/drivers/virt/nitro_enclaves/Kconfig
> @@ -17,7 +17,7 @@ config NITRO_ENCLAVES
> 
>   config NITRO_ENCLAVES_MISC_DEV_TEST
>          bool "Tests for the misc device functionality of the Nitro Enclaves" if !KUNIT_ALL_TESTS
> -       depends on NITRO_ENCLAVES && KUNIT
> +       depends on NITRO_ENCLAVES && KUNIT=y
>          default KUNIT_ALL_TESTS
>          help
>            Enable KUnit tests for the misc device functionality of the Nitro


For the Nitro Enclaves part:

Reviewed-by: Andra Paraschiv <andraprs@...zon.com>

Thank you.

Andra

> --
> 2.36.1
> 



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.