linux-kernel - RE: [PATCH v2 1/3] mm: revert handling Non-LRU pages returned by follow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR11MB34955999A195AAD2614A9339F7689@BYAPR11MB3495.namprd11.prod.outlook.com>
Date:   Mon, 15 Aug 2022 01:02:32 +0000
From:   "Wang, Haiyue" <haiyue.wang@...el.com>
To:     David Hildenbrand <david@...hat.com>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linmiaohe@...wei.com" <linmiaohe@...wei.com>,
        "Huang, Ying" <ying.huang@...el.com>,
        "songmuchun@...edance.com" <songmuchun@...edance.com>,
        "naoya.horiguchi@...ux.dev" <naoya.horiguchi@...ux.dev>,
        "alex.sierra@....com" <alex.sierra@....com>
Subject: RE: [PATCH v2 1/3] mm: revert handling Non-LRU pages returned by
 follow_page

> -----Original Message-----
> From: David Hildenbrand <david@...hat.com>
> Sent: Monday, August 15, 2022 00:31
> To: Wang, Haiyue <haiyue.wang@...el.com>; linux-mm@...ck.org; linux-kernel@...r.kernel.org
> Cc: akpm@...ux-foundation.org; linmiaohe@...wei.com; Huang, Ying <ying.huang@...el.com>;
> songmuchun@...edance.com; naoya.horiguchi@...ux.dev; alex.sierra@....com
> Subject: Re: [PATCH v2 1/3] mm: revert handling Non-LRU pages returned by follow_page
> 
> On 14.08.22 16:05, Haiyue Wang wrote:
> > The commit
> > 3218f8712d6b ("mm: handling Non-LRU pages returned by vm_normal_pages")
> > doesn't handle the follow_page with flag FOLL_GET correctly, this will
> > do get_page on page, it shouldn't just return directly without put_page.
> >
> > So revert the related fix to prepare for clean patch to handle Non-LRU
> > pages returned by follow_page.
> 
> What? Why?
> 

Just as the cover letter said, for applying the PATCH 2/3 can be applied on
Linux-5.19 branch directly. I will drop this kind of fix, and fix the issue
directly in v3.

> Just fix it.
> 
> --
> Thanks,
> 
> David / dhildenb