linux-kernel - Re: [PATCH] thunderbolt: thunderbolt: add vendor's NVM formats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YvnqefDHJM+HQIMG@kroah.com>
Date:   Mon, 15 Aug 2022 08:40:57 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Szuying Chen <chensiying21@...il.com>
Cc:     mika.westerberg@...ux.intel.com, andreas.noever@...il.com,
        michael.jamet@...el.com, YehezkelShB@...il.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Yd_Tseng@...edia.com.tw, Chloe_Chen@...edia.com.tw,
        Richard_Hsu@...edia.com.tw
Subject: Re: [PATCH] thunderbolt: thunderbolt: add vendor's NVM formats

On Mon, Aug 15, 2022 at 12:11:45PM +0800, Szuying Chen wrote:
> +/* ASMedia specific validation mode */
> +#define nvm_upgrade 0
> +#define nvm_add 1
> +#define nvm_write 2

Why is this not an enum?

And why is this specific to a single vendor, yet that vendor name is not
in the #define?

> +struct nvm_asmedia {
> +	u32 date;

__le32?

> +	u32 customerID:16;
> +	u32 version:8;
> +	u32 reserved:8;

Are you sure these bitfields are correct on all platforms?

thanks,

greg k-h