[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <DBBPR08MB45380D6A2BEFD919AFB774BEF7689@DBBPR08MB4538.eurprd08.prod.outlook.com>
Date: Mon, 15 Aug 2022 01:13:35 +0000
From: Justin He <Justin.He@....com>
To: Borislav Petkov <bp@...en8.de>
CC: Ard Biesheuvel <ardb@...nel.org>, Len Brown <lenb@...nel.org>,
James Morse <James.Morse@....com>,
Tony Luck <tony.luck@...el.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Robert Richter <rric@...nel.org>,
Robert Moore <robert.moore@...el.com>,
"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
"devel@...ica.org" <devel@...ica.org>,
"Rafael J . Wysocki" <rafael@...nel.org>,
Shuai Xue <xueshuai@...ux.alibaba.com>,
Jarkko Sakkinen <jarkko@...nel.org>,
"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
nd <nd@....com>, "toshi.kani@....com" <toshi.kani@....com>
Subject: RE: [PATCH 1/2] efi/cper: export several helpers for ghes edac to use
Hi Boris
> -----Original Message-----
> From: Borislav Petkov <bp@...en8.de>
> Sent: Friday, August 12, 2022 10:46 PM
> To: Justin He <Justin.He@....com>
> Cc: Ard Biesheuvel <ardb@...nel.org>; Len Brown <lenb@...nel.org>; James
> Morse <James.Morse@....com>; Tony Luck <tony.luck@...el.com>; Mauro
> Carvalho Chehab <mchehab@...nel.org>; Robert Richter <rric@...nel.org>;
> Robert Moore <robert.moore@...el.com>; linux-acpi@...r.kernel.org;
> linux-kernel@...r.kernel.org; linux-edac@...r.kernel.org; devel@...ica.org;
> Rafael J . Wysocki <rafael@...nel.org>; Shuai Xue
> <xueshuai@...ux.alibaba.com>; Jarkko Sakkinen <jarkko@...nel.org>;
> linux-efi@...r.kernel.org; nd <nd@....com>; toshi.kani@....com
> Subject: Re: [PATCH 1/2] efi/cper: export several helpers for ghes edac to use
>
> On Thu, Aug 11, 2022 at 09:17:12AM +0000, Jia He wrote:
> > Before modularizing the ghes_edac codes, we need to export several
> > efi/cper
>
> Who's we?
>
> Please use passive voice in your commit message: no "we" or "I", etc, and
> describe your changes in imperative mood.
>
> Also, pls read section "2) Describe your changes" in
> Documentation/process/submitting-patches.rst for more details.
>
> Also, see section "Changelog" in
> Documentation/process/maintainer-tip.rst
>
> Bottom line is: personal pronouns are ambiguous in text, especially with so
> many parties/companies/etc developing the kernel so let's avoid them please.
Okay,I will fix the commit description in next version.
--
Cheers,
Justin (Jia He)
Powered by blists - more mailing lists