linux-kernel - Re: [PATCH] drm/sun4i: dsi: Prevent underflow when computing packet sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166054963291.173470.13302885096018416390.b4-ty@cerno.tech>
Date:   Mon, 15 Aug 2022 09:47:14 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     jernej.skrabec@...il.com, wens@...e.org, samuel@...lland.org,
        mripard@...nel.org
Cc:     Maxime Ripard <maxime@...no.tech>, dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org, airlied@...ux.ie,
        daniel@...ll.ch, linux-kernel@...r.kernel.org,
        linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH] drm/sun4i: dsi: Prevent underflow when computing packet sizes

On Thu, 11 Aug 2022 22:16:23 -0500, Samuel Holland wrote:
> Currently, the packet overhead is subtracted using unsigned arithmetic.
> With a short sync pulse, this could underflow and wrap around to near
> the maximal u16 value. Fix this by using signed subtraction. The call to
> max() will correctly handle any negative numbers that are produced.
> 
> Apply the same fix to the other timings, even though those subtractions
> are less likely to underflow.
> 
> [...]

Applied to drm/drm-misc (drm-misc-fixes).

Thanks!
Maxime