linux-kernel - Re: [PATCH] mm: remove duplicate mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220814171750.858b89dca1042fd46ec2fc94@linux-foundation.org>
Date:   Sun, 14 Aug 2022 17:17:50 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Chao Xu <Chao.Xu9@...krlife.com>
Cc:     <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: remove duplicate mm_types.h and unnecessary declare

On Wed, 27 Jul 2022 23:15:27 +0800 Chao Xu <Chao.Xu9@...krlife.com> wrote:

> mm_types.h have already in page-flags.h. Duplicated import
> header file and struct page declare is not needed.

It's better to (as much as possible) explicitly include the needed headers,
rather than reply upon nested includes which might change in the future.

This isn't theoretical.  We regularly get build breakage when rework of
one header exposes unexpected dependencies within another file.