linux-kernel - [PATCH v2] media: rockchip: rga: Fix probe rga_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220815103621.86509-1-kernel@undef.tools>
Date:   Mon, 15 Aug 2022 10:36:22 +0000
From:   Jarrah Gosbell <kernel@...ef.tools>
To:     Jacob Chen <jacob-chen@...wrt.com>,
        Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Heiko Stuebner <heiko@...ech.de>, linux-media@...r.kernel.org,
        linux-rockchip@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     phone-devel@...r.kernel.org, Ondrej Jirman <megi@....cz>,
        Jarrah Gosbell <kernel@...ef.tools>
Subject: [PATCH v2] media: rockchip: rga: Fix probe rga_parse_dt bugs

From: Ondrej Jirman <megi@....cz>

rga_parse_dt is missing a error return, so if some of the resources
return DEFER_PROBE, probe will succeed without these resources.

Signed-off-by: Ondrej Jirman <megi@....cz>
Co-developed-by: Jarrah Gosbell <kernel@...ef.tools>
Signed-off-by: Jarrah Gosbell <kernel@...ef.tools>
---
v1 -> v2: use dev_err_probe to handle -EPROBE_DEFER.

 drivers/media/platform/rockchip/rga/rga.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c
index 2f8df74ad0fd..61b25fcf826e 100644
--- a/drivers/media/platform/rockchip/rga/rga.c
+++ b/drivers/media/platform/rockchip/rga/rga.c
@@ -816,7 +816,7 @@ static int rga_probe(struct platform_device *pdev)
 
 	ret = rga_parse_dt(rga);
 	if (ret)
-		dev_err(&pdev->dev, "Unable to parse OF data\n");
+		return dev_err_probe(&pdev->dev, ret, "Unable to parse OF data\n");
 
 	pm_runtime_enable(rga->dev);
 
-- 
2.35.1