linux-kernel - RE: [PATCH v3 2/2] mm: fix the handling Non-LRU pages returned by follow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Aug 2022 01:46:59 +0000
From:   "Wang, Haiyue" <haiyue.wang@...el.com>
To:     "Huang, Ying" <ying.huang@...el.com>
CC:     "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "david@...hat.com" <david@...hat.com>,
        "linmiaohe@...wei.com" <linmiaohe@...wei.com>,
        "songmuchun@...edance.com" <songmuchun@...edance.com>,
        "naoya.horiguchi@...ux.dev" <naoya.horiguchi@...ux.dev>,
        "alex.sierra@....com" <alex.sierra@....com>,
        Felix Kuehling <Felix.Kuehling@....com>,
        Alistair Popple <apopple@...dia.com>
Subject: RE: [PATCH v3 2/2] mm: fix the handling Non-LRU pages returned by
 follow_page

> -----Original Message-----
> From: Huang, Ying <ying.huang@...el.com>
> Sent: Monday, August 15, 2022 09:40
> To: Wang, Haiyue <haiyue.wang@...el.com>
> Cc: linux-mm@...ck.org; linux-kernel@...r.kernel.org; akpm@...ux-foundation.org; david@...hat.com;
> linmiaohe@...wei.com; songmuchun@...edance.com; naoya.horiguchi@...ux.dev; alex.sierra@....com; Felix
> Kuehling <Felix.Kuehling@....com>; Alistair Popple <apopple@...dia.com>
> Subject: Re: [PATCH v3 2/2] mm: fix the handling Non-LRU pages returned by follow_page
> 
> Haiyue Wang <haiyue.wang@...el.com> writes:
> 
> > The page returned by follow_page with 'FOLL_GET' has get_page called, so
> 
> Better to add "()" after function name to improve the readability, for
> example, "follow_page()".

Got it, didn't notice this. ;-)

> 
> > it needs to call put_page for handling the reference count correctly.
> >
> > And as David reviewed, "device pages are never PageKsm pages". Drop this
> > zone device page check for break_ksm.
> >
> > Fixes: 3218f8712d6b ("mm: handling Non-LRU pages returned by vm_normal_pages")
> 
> In your patch description, I cannot find how the above commit is related
> to the bug you fixed.  Add some words about that?

The first commit session, but maybe not very clear, will try to add more words
In v4.

> 
> Best Regards,
> Huang, Ying
> 
> > Signed-off-by: Haiyue Wang <haiyue.wang@...el.com>
> > ---
> >  mm/huge_memory.c |  4 ++--
> >  mm/ksm.c         | 12 +++++++++---
> >  mm/migrate.c     | 10 +++++++---
> >  3 files changed, 18 insertions(+), 8 deletions(-)
> >