linux-kernel - Re: [PATCH] spi: lpspi: Simplify some error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2796602.mvXUDI8C0e@steina-w>
Date:   Mon, 15 Aug 2022 13:06:34 +0200
From:   Alexander Stein <alexander.stein@...tq-group.com>
To:     Mark Brown <broonie@...nel.org>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        linux-spi@...r.kernel.org
Subject: Re: [PATCH] spi: lpspi: Simplify some error message

Am Freitag, 5. August 2022, 23:39:19 CEST schrieb Christophe JAILLET:
> dev_err_probe() already prints the error code in a human readable way, so
> there is no need to duplicate it as a numerical value at the end of the
> message.
> 
> Fixes: 12f62a857c83 ("spi: lpspi: Silence error message upon deferred
> probe") Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/spi/spi-fsl-lpspi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c
> index 19b1f3d881b0..cbbe8bbef90a 100644
> --- a/drivers/spi/spi-fsl-lpspi.c
> +++ b/drivers/spi/spi-fsl-lpspi.c
> @@ -912,7 +912,7 @@ static int fsl_lpspi_probe(struct platform_device *pdev)
> 
>  	ret = devm_spi_register_controller(&pdev->dev, controller);
>  	if (ret < 0) {
> -		dev_err_probe(&pdev->dev, ret, "spi_register_controller 
error: %i\n",
> ret); +		dev_err_probe(&pdev->dev, ret, "spi_register_controller 
error\n");
> goto free_dma;
>  	}

Acked-By: Alexander Stein <alexander.stein@...tq-group.com>