linux-kernel - Re: [PATCH v5 1/1] gpio: mpfs: add polarfire soc gpio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202208151906.8v7FxH3X-lkp@intel.com>
Date:   Mon, 15 Aug 2022 19:39:35 +0800
From:   kernel test robot <lkp@...el.com>
To:     lewis.hanly@...rochip.com, linux-gpio@...r.kernel.org,
        linux-riscv@...ts.infradead.org, linus.walleij@...aro.org,
        brgl@...ev.pl, linux-kernel@...r.kernel.org, palmer@...belt.com,
        maz@...nel.org
Cc:     kbuild-all@...ts.01.org, conor.dooley@...rochip.com,
        daire.mcnamara@...rochip.com, lewis.hanly@...rochip.com
Subject: Re: [PATCH v5 1/1] gpio: mpfs: add polarfire soc gpio support

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on brgl/gpio/for-next]
[also build test WARNING on linus/master v6.0-rc1 next-20220815]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/lewis-hanly-microchip-com/Add-Polarfire-SoC-GPIO-support/20220815-150808
base:   https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20220815/202208151906.8v7FxH3X-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/0458963d9f39d68b20ed88e71d20ca69d835e7fe
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review lewis-hanly-microchip-com/Add-Polarfire-SoC-GPIO-support/20220815-150808
        git checkout 0458963d9f39d68b20ed88e71d20ca69d835e7fe
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/gpio/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/gpio/gpio-mpfs.c: In function 'mpfs_gpio_irq_handler':
   drivers/gpio/gpio-mpfs.c:203:9: error: 'unisgned' undeclared (first use in this function)
     203 |         unisgned long status;
         |         ^~~~~~~~
   drivers/gpio/gpio-mpfs.c:203:9: note: each undeclared identifier is reported only once for each function it appears in
   drivers/gpio/gpio-mpfs.c:203:17: error: expected ';' before 'long'
     203 |         unisgned long status;
         |                 ^~~~~
         |                 ;
>> drivers/gpio/gpio-mpfs.c:204:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     204 |         int offset;
         |         ^~~
   drivers/gpio/gpio-mpfs.c:208:9: error: 'status' undeclared (first use in this function); did you mean 'kstatfs'?
     208 |         status = readl(mpfs_gpio->base + MPFS_IRQ_REG);
         |         ^~~~~~
         |         kstatfs
   drivers/gpio/gpio-mpfs.c: In function 'mpfs_gpio_probe':
   drivers/gpio/gpio-mpfs.c:268:19: error: 'struct irq_chip' has no member named 'parent_device'
     268 |         girq->chip->parent_device = dev;
         |                   ^~


vim +204 drivers/gpio/gpio-mpfs.c

   197	
   198	static void mpfs_gpio_irq_handler(struct irq_desc *desc)
   199	{
   200		struct irq_chip *irqchip = irq_desc_get_chip(desc);
   201		struct mpfs_gpio_chip *mpfs_gpio =
   202			gpiochip_get_data(irq_desc_get_handler_data(desc));
 > 203		unisgned long status;
 > 204		int offset;
   205	
   206		chained_irq_enter(irqchip, desc);
   207	
   208		status = readl(mpfs_gpio->base + MPFS_IRQ_REG);
   209		for_each_set_bit(offset, &status, mpfs_gpio->gc.ngpio) {
   210			mpfs_gpio_assign_bit(mpfs_gpio->base + MPFS_IRQ_REG, offset, 1);
   211			generic_handle_irq(irq_find_mapping(mpfs_gpio->gc.irq.domain, offset));
   212		}
   213	
   214		chained_irq_exit(irqchip, desc);
   215	}
   216	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp