| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220815131504.65f7b92f@donnerap.cambridge.arm.com>
Date: Mon, 15 Aug 2022 13:15:04 +0100
From: Andre Przywara <andre.przywara@....com>
To: Samuel Holland <samuel@...lland.org>
Cc: Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Arnd Bergmann <arnd@...db.de>,
Hans de Goede <hdegoede@...hat.com>,
Icenowy Zheng <icenowy@...c.io>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Maxime Ripard <mripard@...nel.org>,
Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-sunxi@...ts.linux.dev,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v2 01/10] dt-bindings: sram: sunxi-sram: Clean up the
compatible lists
On Sun, 14 Aug 2022 23:12:38 -0500
Samuel Holland <samuel@...lland.org> wrote:
> Use enumerations where appropriate to combine "const" choices and
> deduplicate fallback compatible strings.
>
> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Signed-off-by: Samuel Holland <samuel@...lland.org>
Verified to be a pure transformation.
Reviewed-by: Andre Przywara <andre.przywara@....com>
Cheers,
Andre
> ---
>
> Changes in v2:
> - New patch to first clean up the binding
>
> .../allwinner,sun4i-a10-system-control.yaml | 81 +++++++------------
> 1 file changed, 31 insertions(+), 50 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> index 1c426c211e36..5055c9081059 100644
> --- a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> +++ b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> @@ -24,32 +24,30 @@ properties:
>
> compatible:
> oneOf:
> - - const: allwinner,sun4i-a10-sram-controller
> + - enum:
> + - allwinner,sun4i-a10-sram-controller
> + - allwinner,sun50i-a64-sram-controller
> deprecated: true
> - - const: allwinner,sun4i-a10-system-control
> - - const: allwinner,sun5i-a13-system-control
> + - enum:
> + - allwinner,sun4i-a10-system-control
> + - allwinner,sun5i-a13-system-control
> + - allwinner,sun8i-a23-system-control
> + - allwinner,sun8i-h3-system-control
> + - allwinner,sun50i-a64-system-control
> + - allwinner,sun50i-h5-system-control
> + - allwinner,sun50i-h616-system-control
> - items:
> - - const: allwinner,sun7i-a20-system-control
> + - enum:
> + - allwinner,suniv-f1c100s-system-control
> + - allwinner,sun7i-a20-system-control
> + - allwinner,sun8i-r40-system-control
> - const: allwinner,sun4i-a10-system-control
> - - const: allwinner,sun8i-a23-system-control
> - - const: allwinner,sun8i-h3-system-control
> - items:
> - const: allwinner,sun8i-v3s-system-control
> - const: allwinner,sun8i-h3-system-control
> - - items:
> - - const: allwinner,sun8i-r40-system-control
> - - const: allwinner,sun4i-a10-system-control
> - - const: allwinner,sun50i-a64-sram-controller
> - deprecated: true
> - - const: allwinner,sun50i-a64-system-control
> - - const: allwinner,sun50i-h5-system-control
> - items:
> - const: allwinner,sun50i-h6-system-control
> - const: allwinner,sun50i-a64-system-control
> - - items:
> - - const: allwinner,suniv-f1c100s-system-control
> - - const: allwinner,sun4i-a10-system-control
> - - const: allwinner,sun50i-h616-system-control
>
> reg:
> maxItems: 1
> @@ -76,43 +74,26 @@ patternProperties:
> - const: allwinner,sun4i-a10-sram-d
> - const: allwinner,sun50i-a64-sram-c
> - items:
> - - const: allwinner,sun5i-a13-sram-a3-a4
> - - const: allwinner,sun4i-a10-sram-a3-a4
> - - items:
> - - const: allwinner,sun7i-a20-sram-a3-a4
> + - enum:
> + - allwinner,sun5i-a13-sram-a3-a4
> + - allwinner,sun7i-a20-sram-a3-a4
> - const: allwinner,sun4i-a10-sram-a3-a4
> - items:
> - - const: allwinner,sun5i-a13-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun7i-a20-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun8i-a23-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun8i-h3-sram-c1
> + - enum:
> + - allwinner,sun5i-a13-sram-c1
> + - allwinner,sun7i-a20-sram-c1
> + - allwinner,sun8i-a23-sram-c1
> + - allwinner,sun8i-h3-sram-c1
> + - allwinner,sun8i-r40-sram-c1
> + - allwinner,sun50i-a64-sram-c1
> + - allwinner,sun50i-h5-sram-c1
> + - allwinner,sun50i-h6-sram-c1
> - const: allwinner,sun4i-a10-sram-c1
> - items:
> - - const: allwinner,sun8i-r40-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun50i-a64-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun50i-h5-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun50i-h6-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun5i-a13-sram-d
> - - const: allwinner,sun4i-a10-sram-d
> - - items:
> - - const: allwinner,sun7i-a20-sram-d
> - - const: allwinner,sun4i-a10-sram-d
> - - items:
> - - const: allwinner,suniv-f1c100s-sram-d
> + - enum:
> + - allwinner,suniv-f1c100s-sram-d
> + - allwinner,sun5i-a13-sram-d
> + - allwinner,sun7i-a20-sram-d
> - const: allwinner,sun4i-a10-sram-d
> - items:
> - const: allwinner,sun50i-h6-sram-c
Powered by blists - more mailing lists