linux-kernel - Re: [PATCH v2] clk: mediatek: gate: Export mtk_clk_register_gates_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220815121957.hmdjsznp4zj2ijmh@blmsp>
Date:   Mon, 15 Aug 2022 14:19:57 +0200
From:   Markus Schneider-Pargmann <msp@...libre.com>
To:     Yassine Oudjana <yassine.oudjana@...il.com>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Chen-Yu Tsai <wenst@...omium.org>,
        Miles Chen <miles.chen@...iatek.com>,
        Chun-Jie Chen <chun-jie.chen@...iatek.com>,
        Yassine Oudjana <y.oudjana@...tonmail.com>,
        Rex-BC Chen <rex-bc.chen@...iatek.com>,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] clk: mediatek: gate: Export
 mtk_clk_register_gates_with_dev

Hi Yassine,

On Sat, Aug 13, 2022 at 09:32:49AM +0100, Yassine Oudjana wrote:
> From: Yassine Oudjana <y.oudjana@...tonmail.com>
> 
> This allows it to be used in drivers built as modules.
> 
> Signed-off-by: Yassine Oudjana <y.oudjana@...tonmail.com>
> Reviewed-by: Chen-Yu Tsai <wenst@...omium.org>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

This change overlaps with my patch [1], I added export symbol for more
functions as it was necessary to build the mt8365 clock driver as a
module. I will rebase after this one was applied.

You already have two reviewed-bys, but if you need one more, here you go
;)

Reviewed-by: Markus Schneider-Pargmann <msp@...libre.com>

Best,
Markus

[1] https://lore.kernel.org/linux-mediatek/20220811084433.2598575-4-msp@baylibre.com/

> ---
> This patch was originally part of a series, and is sent alone now since
> it doesn't depend on the rest of it and can be applied directly:
> https://lore.kernel.org/linux-clk/20220519134728.456643-1-y.oudjana@protonmail.com/
> 
>  drivers/clk/mediatek/clk-gate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/mediatek/clk-gate.c b/drivers/clk/mediatek/clk-gate.c
> index 421806236228..0c867136e49d 100644
> --- a/drivers/clk/mediatek/clk-gate.c
> +++ b/drivers/clk/mediatek/clk-gate.c
> @@ -261,6 +261,7 @@ int mtk_clk_register_gates_with_dev(struct device_node *node,
>  
>  	return PTR_ERR(hw);
>  }
> +EXPORT_SYMBOL_GPL(mtk_clk_register_gates_with_dev);
>  
>  int mtk_clk_register_gates(struct device_node *node,
>  			   const struct mtk_gate *clks, int num,
> -- 
> 2.37.1
> 
>