linux-kernel - Re: [PATCH v7] mm/page_owner.c: add llseek for page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202208152007.a6QeCOGK-lkp@intel.com>
Date:   Mon, 15 Aug 2022 20:40:55 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kassey Li <quic_yingangl@...cinc.com>, akpm@...ux-foundation.org,
        vbabka@...nel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Kassey Li <quic_yingangl@...cinc.com>, minchan@...nel.org,
        vbabka@...e.cz, iamjoonsoo.kim@....com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v7] mm/page_owner.c: add llseek for page_owner

Hi Kassey,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.0-rc1 next-20220815]
[cannot apply to akpm-mm/mm-everything]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Kassey-Li/mm-page_owner-c-add-llseek-for-page_owner/20220815-143155
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 568035b01cfb107af8d2e4bd2fb9aea22cf5b868
config: hexagon-randconfig-r041-20220814 (https://download.01.org/0day-ci/archive/20220815/202208152007.a6QeCOGK-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 6afcc4a459ead8809a0d6d9b4bf7b64bcc13582b)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/f9ef28f8ab55cdd176ab5ce7ad606ca45b4dbcc0
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Kassey-Li/mm-page_owner-c-add-llseek-for-page_owner/20220815-143155
        git checkout f9ef28f8ab55cdd176ab5ce7ad606ca45b4dbcc0
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> mm/page_owner.c:575:8: warning: no previous prototype for function 'lseek_page_owner' [-Wmissing-prototypes]
   loff_t lseek_page_owner(struct file *file, loff_t offset, int orig)
          ^
   mm/page_owner.c:575:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   loff_t lseek_page_owner(struct file *file, loff_t offset, int orig)
   ^
   static 
   1 warning generated.


vim +/lseek_page_owner +575 mm/page_owner.c

   574	
 > 575	loff_t lseek_page_owner(struct file *file, loff_t offset, int orig)
   576	{
   577		switch (orig) {
   578		case SEEK_SET:
   579			file->f_pos = offset;
   580			break;
   581		case SEEK_CUR:
   582			file->f_pos += offset;
   583			break;
   584		default:
   585			return -EINVAL;
   586		}
   587		return file->f_pos;
   588	}
   589	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp