linux-kernel - Re: [PATCH v5 04/33] thermal/drivers/uniphier: Switch to new of API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fcb9c36a-1e4f-f406-6309-9661392936db@socionext.com>
Date:   Mon, 15 Aug 2022 23:18:04 +0900
From:   Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To:     Daniel Lezcano <daniel.lezcano@...exp.org>,
        daniel.lezcano@...aro.org, rafael@...nel.org
Cc:     rui.zhang@...el.com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, khilman@...libre.com,
        abailon@...libre.com, lukasz.luba@....com, broonie@...nel.org,
        damien.lemoal@...nsource.wdc.com, heiko@...ech.de,
        mhiramat@...nel.org, talel@...zon.com, thierry.reding@...il.com,
        digetx@...il.com, jonathanh@...dia.com, anarsoul@...il.com,
        tiny.windzz@...il.com, baolin.wang7@...il.com,
        f.fainelli@...il.com, bjorn.andersson@...aro.org,
        mcoquelin.stm32@...il.com, glaroque@...libre.com,
        miquel.raynal@...tlin.com, shawnguo@...nel.org,
        niklas.soderlund@...natech.se, matthias.bgg@...il.com,
        j-keerthy@...com, Amit Kucheria <amitk@...nel.org>,
        "moderated list:ARM/UNIPHIER ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v5 04/33] thermal/drivers/uniphier: Switch to new of API

On 2022/08/05 7:43, Daniel Lezcano wrote:
> The thermal OF code has a new API allowing to migrate the OF
> initialization to a simpler approach. The ops are no longer device
> tree specific and are the generic ones provided by the core code.
> 
> Convert the ops to the thermal_zone_device_ops format and use the new
> API to register the thermal zone with these generic ops.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...exp.org>

Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>

> ---
>   drivers/thermal/uniphier_thermal.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/thermal/uniphier_thermal.c
> b/drivers/thermal/uniphier_thermal.c
> index 4cae5561a2a3..4111d99ef50e 100644
> --- a/drivers/thermal/uniphier_thermal.c
> +++ b/drivers/thermal/uniphier_thermal.c
> @@ -187,9 +187,9 @@ static void uniphier_tm_disable_sensor(struct
> uniphier_tm_dev *tdev)
>   	usleep_range(1000, 2000);	/* The spec note says at least 1ms
> */
>   }
>   
> -static int uniphier_tm_get_temp(void *data, int *out_temp)
> +static int uniphier_tm_get_temp(struct thermal_zone_device *tz, int
> *out_temp)
>   {
> -	struct uniphier_tm_dev *tdev = data;
> +	struct uniphier_tm_dev *tdev = tz->devdata;
>   	struct regmap *map = tdev->regmap;
>   	int ret;
>   	u32 temp;
> @@ -204,7 +204,7 @@ static int uniphier_tm_get_temp(void *data, int
> *out_temp)
>   	return 0;
>   }
>   
> -static const struct thermal_zone_of_device_ops uniphier_of_thermal_ops =
> {
> +static const struct thermal_zone_device_ops uniphier_of_thermal_ops = {
>   	.get_temp = uniphier_tm_get_temp,
>   };
>   
> @@ -289,8 +289,8 @@ static int uniphier_tm_probe(struct platform_device
> *pdev)
>   
>   	platform_set_drvdata(pdev, tdev);
>   
> -	tdev->tz_dev = devm_thermal_zone_of_sensor_register(dev, 0, tdev,
> -						&uniphier_of_thermal_ops);
> +	tdev->tz_dev = devm_thermal_of_zone_register(dev, 0, tdev,
> +						
> &uniphier_of_thermal_ops);
>   	if (IS_ERR(tdev->tz_dev)) {
>   		dev_err(dev, "failed to register sensor device\n");
>   		return PTR_ERR(tdev->tz_dev);
> 

---
Best Regards
Kunihiko Hayashi