linux-kernel - Re: [PATCH v1 1/2] zsmalloc: zs_object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yvm0//iPcvbW1M55@google.com>
Date:   Mon, 15 Aug 2022 11:52:47 +0900
From:   Sergey Senozhatsky <senozhatsky@...omium.org>
To:     Alexey Romanov <avromanov@...rdevices.ru>
Cc:     minchan@...nel.org, senozhatsky@...omium.org, ngupta@...are.org,
        akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, kernel@...rdevices.ru
Subject: Re: [PATCH v1 1/2] zsmalloc: zs_object_copy: add clarifying comment

On (22/08/11 18:37), Alexey Romanov wrote:
> @@ -1564,6 +1564,12 @@ static void zs_object_copy(struct size_class *class, unsigned long dst,
>  		d_off += size;
>  		d_size -= size;
>  
> +		/* Calling kunmap_atomic(d_addr) is necessary. kunmap_atomic() calls
> +		 * must occurs in reverse order of calls to kmap_atomic().
> +		 * So, to call kunmap_atomic(s_addr) we should first call kunmap_atomic(d_addr).
> +		 * For more details see:
> +		 * https://lore.kernel.org/linux-mm/5512421D.4000603@samsung.com/
> +		 */

I'd drop the link part, Emails are not documentation, kmap_atomic
is documented in Documentation/mm/highmem