linux-kernel - Re: [PATCH] Kconfig: eliminate abnormal characters displayed under menuconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Aug 2022 18:18:57 +0100
From:   Simon Horman <horms@...ge.net.au>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Liu Song <liusong@...ux.alibaba.com>, bhelgaas@...gle.com,
        pablo@...filter.org, davem@...emloft.net, nathan@...nel.org,
        apw@...onical.com, joe@...ches.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Kconfig: eliminate abnormal characters displayed under
 menuconfig

On Mon, Aug 08, 2022 at 09:51:47PM -0500, Bjorn Helgaas wrote:
> On Tue, Aug 02, 2022 at 06:12:33PM +0800, Liu Song wrote:
> > From: Liu Song <liusong@...ux.alibaba.com>
> > 
> > Use "find ./linux/* | grep Kconfig | xargs file | grep UTF", can find
> > files with utf-8 encoded characters, these files will display garbled
> > characters in menuconfig, except for characters with special meanings
> > that cannot be modified, modify the characters with obvious errors to
> > eliminate the wrong display under meunconfig.
> > 
> > Signed-off-by: Liu Song <liusong@...ux.alibaba.com>
> > Suggested-by: Bjorn Helgaas <helgaas@...nel.org>
> 
> I did suggest fixing everything at once.  But I think there are
> actually two problems here.  The first is that some are just wrong,
> e.g., drivers/pci/Kconfig using CYRILLIC SMALL LETTER DZE instead of
> "s", or net/netfilter/ipvs/Kconfig using NO-BREAK SPACE for no good
> reason.
> 
> arch/Kconfig looks like it's using RIGHT SINGLE QUOTATION MARK instead
> of the basic APOSTROPHE.  That one is debatable; I think it's fair to
> argue that RIGHT SINGLE QUOTATION MARK would be preferred if rendered
> correctly.
> 
> The second problem is that I think menuconfig doesn't handle UTF-8
> correctly.  For example, in a gnome terminal with the default
> LC_ALL=en_US.UTF-8, these look fine:
> 
>   $ grep -A10 MTD_SPI_NOR_USE_4K_SECTORS drivers/mtd/spi-nor/Kconfig
>   ...
>   64 KiB block instead of 16 × 4 KiB sectors.
> 
>   $ grep -A1 MTD_NAND_CAFE drivers/mtd/nand/raw/Kconfig
>   config MTD_NAND_CAFE
> 	tristate "OLPC CAFÉ NAND controller"
> 
> But when menuconfig in the same terminal displays that same text, it
> looks like "16  ~W 4 KiB sectors" and "OLPC CAF ~I NAND".
> 
> On the other hand, gconfig and xconfig do render these correctly.  So
> I think there's something wrong with UTF-8 in menuconfig, and we
> should fix that as well.
> 
> Anyway, I'm fine with this patch as far as it goes:
> 
> Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>

IPVS portion:

Acked-by: Simon Horman <horms@...ge.net.au>