linux-kernel - [linux-stable-rc:linux-5.10.y 6780/7990] drivers/gpu/drm/msm/dp/dp_display.c:523:26: warning: variable 'hpd' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 16 Aug 2022 09:56:20 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kuogee Hsieh <khsieh@...eaurora.org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Clark <robdclark@...omium.org>,
        Sasha Levin <sashal@...nel.org>
Subject: [linux-stable-rc:linux-5.10.y 6780/7990]
 drivers/gpu/drm/msm/dp/dp_display.c:523:26: warning: variable 'hpd' set but
 not used

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
head:   71f2154ac93f2d6cf536292c7c72b410e05c8041
commit: acf76125bb2b247d27cb4ca57fda772c8a691fe9 [6780/7990] drm/msm/dp: fix connect/disconnect handled at irq_hpd
config: arm64-buildonly-randconfig-r006-20220815 (https://download.01.org/0day-ci/archive/20220816/202208160913.aFS2WTCD-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=acf76125bb2b247d27cb4ca57fda772c8a691fe9
        git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
        git fetch --no-tags linux-stable-rc linux-5.10.y
        git checkout acf76125bb2b247d27cb4ca57fda772c8a691fe9
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/gpu/drm/msm/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/msm/dp/dp_display.c: In function 'dp_display_usbpd_attention_cb':
>> drivers/gpu/drm/msm/dp/dp_display.c:523:26: warning: variable 'hpd' set but not used [-Wunused-but-set-variable]
     523 |         struct dp_usbpd *hpd;
         |                          ^~~


vim +/hpd +523 drivers/gpu/drm/msm/dp/dp_display.c

c943b4948b5848 Chandan Uddaraju 2020-08-27  517  
c943b4948b5848 Chandan Uddaraju 2020-08-27  518  static int dp_display_usbpd_attention_cb(struct device *dev)
c943b4948b5848 Chandan Uddaraju 2020-08-27  519  {
c943b4948b5848 Chandan Uddaraju 2020-08-27  520  	int rc = 0;
61f8f4034c0423 Kuogee Hsieh     2020-11-03  521  	u32 sink_request;
c943b4948b5848 Chandan Uddaraju 2020-08-27  522  	struct dp_display_private *dp;
61f8f4034c0423 Kuogee Hsieh     2020-11-03 @523  	struct dp_usbpd *hpd;
c943b4948b5848 Chandan Uddaraju 2020-08-27  524  
c943b4948b5848 Chandan Uddaraju 2020-08-27  525  	if (!dev) {
c943b4948b5848 Chandan Uddaraju 2020-08-27  526  		DRM_ERROR("invalid dev\n");
c943b4948b5848 Chandan Uddaraju 2020-08-27  527  		return -EINVAL;
c943b4948b5848 Chandan Uddaraju 2020-08-27  528  	}
c943b4948b5848 Chandan Uddaraju 2020-08-27  529  
061eb621fc2780 Abhinav Kumar    2020-09-12  530  	dp = container_of(g_dp_display,
061eb621fc2780 Abhinav Kumar    2020-09-12  531  			struct dp_display_private, dp_display);
c943b4948b5848 Chandan Uddaraju 2020-08-27  532  	if (!dp) {
c943b4948b5848 Chandan Uddaraju 2020-08-27  533  		DRM_ERROR("no driver data found\n");
c943b4948b5848 Chandan Uddaraju 2020-08-27  534  		return -ENODEV;
c943b4948b5848 Chandan Uddaraju 2020-08-27  535  	}
c943b4948b5848 Chandan Uddaraju 2020-08-27  536  
61f8f4034c0423 Kuogee Hsieh     2020-11-03  537  	hpd = dp->usbpd;
61f8f4034c0423 Kuogee Hsieh     2020-11-03  538  
c943b4948b5848 Chandan Uddaraju 2020-08-27  539  	/* check for any test request issued by sink */
8ede2ecc3e5ee3 Kuogee Hsieh     2020-09-11  540  	rc = dp_link_process_request(dp->link);
61f8f4034c0423 Kuogee Hsieh     2020-11-03  541  	if (!rc) {
61f8f4034c0423 Kuogee Hsieh     2020-11-03  542  		sink_request = dp->link->sink_request;
acf76125bb2b24 Kuogee Hsieh     2020-11-18  543  		if (sink_request & DS_PORT_STATUS_CHANGED)
acf76125bb2b24 Kuogee Hsieh     2020-11-18  544  			rc = dp_display_handle_port_ststus_changed(dp);
acf76125bb2b24 Kuogee Hsieh     2020-11-18  545  		else
61f8f4034c0423 Kuogee Hsieh     2020-11-03  546  			rc = dp_display_handle_irq_hpd(dp);
61f8f4034c0423 Kuogee Hsieh     2020-11-03  547  	}
c943b4948b5848 Chandan Uddaraju 2020-08-27  548  
8ede2ecc3e5ee3 Kuogee Hsieh     2020-09-11  549  	return rc;
c943b4948b5848 Chandan Uddaraju 2020-08-27  550  }
c943b4948b5848 Chandan Uddaraju 2020-08-27  551  

:::::: The code at line 523 was first introduced by commit
:::::: 61f8f4034c04231148e7580ae51a2a74171c04a0 drm/msm/dp: promote irq_hpd handle to handle link training correctly

:::::: TO: Kuogee Hsieh <khsieh@...eaurora.org>
:::::: CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp