linux-kernel - Re: linux-next: Tree for Aug 15 (input/misc/ibm-panel.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YvsaCjnkucMeyj60@google.com>
Date:   Mon, 15 Aug 2022 21:16:10 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Eddie James <eajames@...ux.ibm.com>,
        linux-input@...r.kernel.org, Wolfram Sang <wsa@...nel.org>
Subject: Re: linux-next: Tree for Aug 15 (input/misc/ibm-panel.c)

On Mon, Aug 15, 2022 at 06:26:43PM -0700, Randy Dunlap wrote:
> 
> 
> On 8/14/22 19:29, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20220812:
> > 
> 
> on x86_64:
> 
> when CONFIG_I2C=m and CONFIG_I2C_SLAVE=y:
> 
> ld: drivers/input/misc/ibm-panel.o: in function `ibm_panel_remove':
> ibm-panel.c:(.text+0x16): undefined reference to `i2c_slave_unregister'
> ld: drivers/input/misc/ibm-panel.o: in function `ibm_panel_probe':
> ibm-panel.c:(.text+0x3e3): undefined reference to `i2c_slave_register'
> ld: drivers/input/misc/ibm-panel.o: in function `ibm_panel_driver_init':
> ibm-panel.c:(.init.text+0x18): undefined reference to `i2c_register_driver'
> ld: drivers/input/misc/ibm-panel.o: in function `ibm_panel_driver_exit':
> ibm-panel.c:(.exit.text+0x11): undefined reference to `i2c_del_driver'

It sounds like I need to adjust the depend statement to be:

	depends on I2C && I2C_SLAVE

Thanks.

-- 
Dmitry