linux-kernel - Re: [PATCH] m68k: Complete variable type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 Aug 2022 07:24:17 +0100
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Greg Ungerer <gerg@...ux-m68k.org>
Cc:     Xin Gao <gaoxin@...rlc.com>, geert@...ux-m68k.org,
        linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k: Complete variable type

On Tue, Aug 16, 2022 at 09:37:19AM +1000, Greg Ungerer wrote:
> On 16/8/22 05:48, Xin Gao wrote:
> > @@ -169,7 +169,7 @@ void q40_sched_init (void)
> >    *
> >   */
> > -struct IRQ_TABLE{ unsigned int mask; int irq ;};
> > +struct IRQ_TABLE{ unsigned int mask; int irq };
> >   #if 0
> >   static struct IRQ_TABLE iirqs[]={
> >     {Q40_IRQ_FRAME_MASK,Q40_IRQ_FRAME},
> 
> This last change doesn't match the commit message.
> It should be a separate patch.

	The last change is not a valid C.  Never had been.
In C semicolon is *NOT* a separator - it's a part of declaration.

-- 
improve the kernel quality - git rm scripts/checkpatch.pl