linux-kernel - Re: [PATCH] dt-bindings: pinctrl: mt8186: Fix 'reg-names' for pinctrl nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c411c5c5-0a8b-c85c-2d57-1a387eb0d28f@linaro.org>
Date:   Tue, 16 Aug 2022 10:14:55 +0300
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Allen-KH Cheng <allen-kh.cheng@...iatek.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>
Cc:     Project_Global_Chrome_Upstream_Group@...iatek.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        Guodong Liu <guodong.liu@...iatek.com>
Subject: Re: [PATCH] dt-bindings: pinctrl: mt8186: Fix 'reg-names' for pinctrl
 nodes

On 15/08/2022 15:25, Allen-KH Cheng wrote:
> There are 8 GPIO physical address bases in mt8186, corresponding to the
> items of 'reg-names' with the pinctrl driver. but the order of

New sentences start with capital letter.

> 'reg-names' is not correct. The mt8186 pinctrl driver would get the
> wrong address, causing the system to restart when regulator initializes
> . we 

^^^ Something is missing. Sentence looks unfinished, full stop is in new
line, next sentence does not start with capital letter.


> fix 'reg-names' for pinctrl nodes and the pinctrl-mt8186 example
> in bindings.
> 
> Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl file and binding document")
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@...iatek.com>
> Signed-off-by: Guodong Liu <guodong.liu@...iatek.com>
> ---
Best regards,
Krzysztof